Bug 191451 - audio/sdl_sound: Improvement patch Timidity selection
Summary: audio/sdl_sound: Improvement patch Timidity selection
Status: Closed Feedback Timeout
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Dmitry Marakasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-06-28 07:45 UTC by Toni Ballesta
Modified: 2019-01-27 08:50 UTC (History)
2 users (show)

See Also:

Attachments
Patch for TIMIDITY selection (1.22 KB, patch)
2014-06-28 07:45 UTC, Toni Ballesta 		no flags Details | Diff
Patch for TIMIDITY selection (1.35 KB, patch)
2014-06-28 09:06 UTC, Toni Ballesta 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Toni Ballesta 2014-06-28 07:45:11 UTC 
Created attachment 144213 [details]
Patch for TIMIDITY selection

With original sdl_sound I can only select build of Timidity, but if Timidity++ is on the system, the installation causes a conflict installing files on the same place.

This patch solve this, by user config selection. Timidity++ works perfectly with SDL_sound.
Comment 1 Toni Ballesta 2014-06-28 09:06:54 UTC 
Created attachment 144215 [details]
Patch for TIMIDITY selection
Comment 2 Toni Ballesta 2014-06-28 09:07:34 UTC 
/usr/local/bin/timidity is for Timidity++, and /bin/timidity is for Timidity. I thinking for change this too. Bug #176969 mentions other problem, not the same but affects this directly.

Now, with this path, solved it. Original Timidity now can do any patch, because sdl_sound only find the executable.
Comment 3 Toni Ballesta 2014-06-28 09:39:27 UTC 
On my patch, the PORTREVISION are untouched.
Comment 4 fiziologus 2014-07-08 04:31:37 UTC 
sdl_sound (as and sdl_mixer) no depend to timidity (both use internal timidity module). Need only midi patch files.
Comment 5 Toni Ballesta 2014-07-08 17:48:12 UTC 
I'm not really sure... if no timidity installed on the system, the original Makefile builds Timidity. Now, I can select if Timidity or Timidity++ (or nothing).
Comment 6 fiziologus 2014-07-12 20:07:02 UTC 
View sdl_mixer Makefile (TIMIDITY options). Both sdl_sound and sdl_mixer use same timidity module.
Comment 7 Toni Ballesta 2014-07-27 17:51:09 UTC 
Today I'm rebuilding the system from port fetching, and sdl_sound fails again due to conflicts with timidity++. Applying this patch and selecting timidity++ solves this problem.
Comment 8 Marcus von Appen freebsd_committer freebsd_triage 2014-09-02 18:38:36 UTC 
Thanks, I'm looking into this. There might be conflicts in the expected behaviour
with bug 176969 and bug 176968, though.
Comment 9 Toni Ballesta 2015-04-18 07:53:39 UTC 
Now, I've installed the SDL game and it now requires sdl_mixer instead of sdl_audio. I think, if sdl_mixer configuration permit, regenerate this patch for his Makefile and select if user need MIDI or not, and then select if need timidity or t++.

Regards.
Comment 10 Rene Ladan freebsd_committer freebsd_triage 2017-01-22 22:32:50 UTC 
Maintainer reset.
Comment 11 Walter Schwarzenfeld 2018-01-13 01:30:20 UTC 
Is this still relevant?
Comment 12 Toni Ballesta 2018-01-14 15:14:17 UTC 
(In reply to w.schwarzenfeld from comment #11)
Sdl_mixer have the option to change, so this bug is obsolete.

Thanks.
Comment 13 Toni Ballesta 2018-01-14 15:16:50 UTC 
Due to package removed, this patch is not necessary now.
Comment 14 Toni Ballesta 2018-01-14 15:19:04 UTC 
Ops, I'm mistaking, the sdl_sound is not removed...
Comment 15 Tobias Kortkamp freebsd_committer freebsd_triage 2019-01-27 08:50:39 UTC 
This patch as proposed here no longer applies to the port.  If this is still
relevant to someone then please rebase on the latest revision and reopen.