Bug 191462 - [opensolaris] cpu_core should be marked in opensolaris export_syms
Summary: [opensolaris] cpu_core should be marked in opensolaris export_syms
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Only Me
Assignee: Mark Johnston
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2014-06-28 16:33 UTC by me.freebsd@cgf.cx
Modified: 2019-04-27 05:36 UTC (History)
3 users (show)

See Also:


Attachments
opensolaris Makefile patch (277 bytes, patch)
2014-06-28 16:33 UTC, me.freebsd@cgf.cx
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description me.freebsd@cgf.cx 2014-06-28 16:33:39 UTC
Created attachment 144224 [details]
opensolaris Makefile patch

The opensolaris module contains a global "cpu_core" that is used in dtrace.  IMO, this means that it should be marked as exported.

We found because dtrace would not load after stripping the unstripped opensolaris.ko module which yielded this:

link_elf_obj (2): 1 symbol cpu_core undefined
linker_load_file: Unsupported file type
KLD dtraceall.ko: depends on dtrace - not available or version mismatch

So, I propose the attached simple patch to rectify this issue.
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2014-07-05 23:56:00 UTC
rpaulo, is this of interest?
Comment 2 commit-hook freebsd_committer 2019-04-20 11:34:57 UTC
A commit references this bug:

Author: markj
Date: Sat Apr 20 11:34:54 UTC 2019
New revision: 346440
URL: https://svnweb.freebsd.org/changeset/base/346440

Log:
  Export cpu_core from opensolaris.ko.

  It is referenced by dtrace*.ko.

  PR:		191462
  Submitted by:	me.freebsd@cgf.cx
  MFC after:	1 week

Changes:
  head/sys/modules/opensolaris/Makefile
Comment 3 commit-hook freebsd_committer 2019-04-27 05:36:06 UTC
A commit references this bug:

Author: markj
Date: Sat Apr 27 05:35:20 UTC 2019
New revision: 346785
URL: https://svnweb.freebsd.org/changeset/base/346785

Log:
  MFC r346440:
  Export cpu_core from opensolaris.ko.

  PR:	191462

Changes:
_U  stable/12/
  stable/12/sys/modules/opensolaris/Makefile
Comment 4 commit-hook freebsd_committer 2019-04-27 05:36:10 UTC
A commit references this bug:

Author: markj
Date: Sat Apr 27 05:35:52 UTC 2019
New revision: 346786
URL: https://svnweb.freebsd.org/changeset/base/346786

Log:
  MFC r346440:
  Export cpu_core from opensolaris.ko.

  PR:	191462

Changes:
_U  stable/11/
  stable/11/sys/modules/opensolaris/Makefile