Bug 191725 - [PATCH] www/fcgi-devkit: Fix license.
Summary: [PATCH] www/fcgi-devkit: Fix license.
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Baptiste Daroussin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-07 23:09 UTC by Matthias Andree
Modified: 2014-07-16 06:05 UTC (History)
3 users (show)

See Also:


Attachments
fcgi-devkit-2.4.0.patch (1.79 KB, patch)
2014-07-07 23:09 UTC, Matthias Andree
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matthias Andree freebsd_committer freebsd_triage 2014-07-07 23:09:33 UTC
Created attachment 144502 [details]
fcgi-devkit-2.4.0.patch

- Fix LICENSE* variables.
- Add trailing slahes to INSTALL_MAN lines for robustness
  of file <-> directory mismatches.
- Replace @dirrmtry by @dirrm

Port maintainer (freebsd@skysmurf.nl) is cc'd.

Generated with FreeBSD Port Tools 1.02 (mode: change, diff: SVN)
Comment 1 A.J. "Fonz" van Werven 2014-07-08 11:32:43 UTC
Maintainer approved.
Comment 2 commit-hook freebsd_committer freebsd_triage 2014-07-08 13:02:20 UTC
A commit references this bug:

Author: pi
Date: Tue Jul  8 13:01:26 UTC 2014
New revision: 361229
URL: http://svnweb.freebsd.org/changeset/ports/361229

Log:
  www/fcgi: Some fixes

  - Fix LICENSE* variables.
  - Add trailing slahes to INSTALL_MAN lines for robustness
    of file <-> directory mismatches.
  - Replace @dirrmtry by @dirrm

  PR:		191725
  Submitted by:	Matthias Andree <mandree@FreeBSD.org>
  Approved by:	freebsd@skysmurf.nl (maintainer)

Changes:
  head/www/fcgi/Makefile
  head/www/fcgi/pkg-plist
Comment 3 Baptiste Daroussin freebsd_committer freebsd_triage 2014-07-09 14:43:22 UTC
Nice shot at breaking fcgi building on cluster just before package building ;) I have fixed the license usage for now
Comment 4 Matthias Andree freebsd_committer freebsd_triage 2014-07-09 14:55:56 UTC
bapt, the requisite permissions for package build are there.
Please provide failure logs so we can see what's going on and debug the package building framework - Note licenses must be queried at install time, not at build time as long as there is permission to build/distribute packages.
Comment 5 A.J. "Fonz" van Werven 2014-07-09 16:22:28 UTC
Just to be clear: was the breakage due to the license acceptance dialog, or were there other problems?
Comment 6 Baptiste Daroussin freebsd_committer freebsd_triage 2014-07-16 06:05:46 UTC
The breakage was due to the fact that the default permissions were set to not accept the license, so packaging was allowed once the license was accepted which results in the package not being built at all. because on the cluster BATCH is set so the licensing framwork falls back on the default aka the license is not accepted