Bug 191747 - [tests] Build failure with MK_TESTS == no and either TARGET=arm/TARGET=armeb or CC=gcc*
Summary: [tests] Build failure with MK_TESTS == no and either TARGET=arm/TARGET=armeb ...
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: misc (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-08 20:15 UTC by Enji Cooper
Modified: 2014-08-05 22:01 UTC (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Enji Cooper freebsd_committer freebsd_triage 2014-07-08 20:15:05 UTC 
There are several issues with the rtld-elf testcases that need to be addressed in
order to enable the test on all architectures with a "test tinderbox":

1. The tests are not relocatable; they should be using atf_tc_get_config(&tc, "srcdir") instead of hardcoding the path to the tests.
2. There's an implied libm dependency that isn't fully spelled out (for some odd reason this passes amd64 and i386, but not arm/armeb).
3. clang spit out a -Wformat error because the bad_library_directories testcase specified a constant string instead of a format string and provided variadic arguments to asprintf.
4. The libexec/rtld-elf/tests/target Makefile was abusing LDFLAGS.
5. Some of the Makefiles were improperly adding ${TESTSDIR} to ${BINDIR} and ${LIBDIR}.

I made the necessary changes here and have run it through a buildworld with amd64 and arm/armeb: https://github.com/yaneurabeya/freebsd/commit/c7a2c463f5e2dbfb04e1826c52d175448c81e35d