Bug 191787 - Fix graphics/libpano13 options usage
Summary: Fix graphics/libpano13 options usage
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Dmitry Marakasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-10 19:02 UTC by Matthieu Volat
Modified: 2014-12-11 10:50 UTC (History)
1 user (show)

See Also:


Attachments
Use options and follows portlint suggestions (1.55 KB, patch)
2014-07-10 19:02 UTC, Matthieu Volat
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matthieu Volat 2014-07-10 19:02:12 UTC
Created attachment 144558 [details]
Use options and follows portlint suggestions

graphics/libpano13 relies on the WITHOUT_JAVA variable in make.conf to enable/disable java support, here is a patch that convert this to the standard Options framework (+ multiples fixes suggested by portlint).

I've taken liberaly the choice to put java to off by default since it seems to me libpano13 main usage is a dependency of graphics/hugin which do not need it, feel free to enable it by default.
Comment 1 Dmitry Marakasov freebsd_committer 2014-12-11 10:49:23 UTC
Maintainer timeout; take.
Comment 2 commit-hook freebsd_committer 2014-12-11 10:50:44 UTC
A commit references this bug:

Author: amdmi3
Date: Thu Dec 11 10:50:37 UTC 2014
New revision: 374523
URL: https://svnweb.freebsd.org/changeset/ports/374523

Log:
  - Add LICENSE
  - Properly OPTIONize java support

  PR:		191787
  Submitted by:	mazhe@alkumuna.eu
  Approved by:	maintainer timeout (vd, 5 months)

Changes:
  head/graphics/libpano13/Makefile