Bug 191793 - [NEW PORT] misc/fortune-mod-epictetus - quotes from Epictetus
Summary: [NEW PORT] misc/fortune-mod-epictetus - quotes from Epictetus
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-10 21:11 UTC by Andy Kosela
Modified: 2014-07-11 14:59 UTC (History)
2 users (show)

See Also:

Attachments
fortune-mod-epictetus.shar (1.97 KB, text/plain)
2014-07-10 21:11 UTC, Andy Kosela 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Kosela 2014-07-10 21:11:01 UTC 
Created attachment 144563 [details]
fortune-mod-epictetus.shar

fortune-mod-epictetus is a compilation of quotes from ancient
philosopher Epictetus.  They come from "A Selection from the Discourses
of Epictetus with the Encheiridion" translated by George Long.

WWW: http://github.com/akosela/fortune-mod-epictetus
Comment 1 Adam Weinberger freebsd_committer freebsd_triage 2014-07-10 22:24:07 UTC 
You have hardcoded paths into /usr/share. Everything needs to be in /usr/local. Have a read through hier(7) and look at what other fortune-mod-* ports do (ex. /usr/ports/misc/fortune-mod-bofh).
Comment 2 Andy Kosela 2014-07-11 00:38:01 UTC 
I did it on purpose.  It seems the default behavior of fortune(6) is not as intended when dealing with additional fortune packages from ports.

sun # pkg info -s fortune-mod-bofh
fortune-mod-bofh-2.0_3         32.1KiB
sun # fortune -f all
___% /usr/share/games/fortune
    ___% freebsd-tips
    ___% murphy
    ___% fortunes
    ___% startrek
    ___% gerrold.limerick
    ___% zippy
    ___% limerick

Without first exporting FORTUNE_PATH all those additional fortune files will not be searched when using 'all' option and I don't think that explicitly exporting this variable is the cleanest thing to do here.

Your thoughts?  Maybe we should patch fortune(6) so that it searches through /usr/local/share/games/fortune also by default?
Comment 3 Andy Kosela 2014-07-11 01:19:41 UTC 
Adam,

For the time being to comply with the other fortune-mod-* ports, just add ${PREFIX} to Makefile.
Comment 4 commit-hook freebsd_committer freebsd_triage 2014-07-11 14:25:58 UTC 
A commit references this bug:

Author: adamw
Date: Fri Jul 11 14:25:40 UTC 2014
New revision: 361539
URL: http://svnweb.freebsd.org/changeset/ports/361539

Log:
  Add misc/fortune-mod-epictetus

  fortune-mod-epictetus is a compilation of quotes from ancient
  philosopher Epictetus.  They come from "A Selection from the Discourses
  of Epictetus with the Encheiridion" translated by George Long.

  WWW: http://github.com/akosela/fortune-mod-epictetus

  PR:		191793
  Submitted by:	Andy Kosela

Changes:
  head/misc/Makefile
  head/misc/fortune-mod-epictetus/
  head/misc/fortune-mod-epictetus/Makefile
  head/misc/fortune-mod-epictetus/distinfo
  head/misc/fortune-mod-epictetus/pkg-descr
Comment 5 Adam Weinberger freebsd_committer freebsd_triage 2014-07-11 14:30:28 UTC 
Committed with small modification (USES=tar:bzip2 instead of USE_BZIP2, which is deprecated).

You are completely right, of course, that the problem here is with fortune(6), not the port. I would heartily support you submitting a patch for fortune to make it also look for fortune files in /usr/local.
Comment 6 Andy Kosela 2014-07-11 14:59:16 UTC 
(In reply to Adam Weinberger from comment #5)
> Committed with small modification (USES=tar:bzip2 instead of USE_BZIP2,
> which is deprecated).
> 
> You are completely right, of course, that the problem here is with
> fortune(6), not the port. I would heartily support you submitting a patch
> for fortune to make it also look for fortune files in /usr/local.

#191800 submitted with a patch.