Bug 191998 - x11/kdelibs4 non-necessary dependency to avahi
Summary: x11/kdelibs4 non-necessary dependency to avahi
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-kde (group)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-21 07:11 UTC by Matthieu Volat
Modified: 2016-07-13 18:53 UTC (History)
3 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Matthieu Volat 2014-07-21 07:11:49 UTC
Hi,

While kdelibs should be able to use either nothing, mdnsd or avahi (I tend to prefer the second as a dev and as a user), the LIB_DEPENDS have a avahi-app line that do not take into account the OPTION choice:

This one can be removed, if the user did set the AVAHI option, avahi-libdns will pull that (amongst others). If he did not set anything, or did set MDNSRESPONDER, this is not needed.

Index: Makefile
===================================================================
--- Makefile	(revision 362401)
+++ Makefile	(working copy)
@@ -14,7 +14,6 @@
 LIB_DEPENDS=	libIlmImf.so:${PORTSDIR}/graphics/OpenEXR \
 		libjasper.so:${PORTSDIR}/graphics/jasper \
 		libpcre.so:${PORTSDIR}/devel/pcre \
-		libavahi-core.so:${PORTSDIR}/net/avahi-app \
 		libenchant.so:${PORTSDIR}/textproc/enchant \
 		libgif.so:${PORTSDIR}/graphics/giflib \
 		libpng15.so:${PORTSDIR}/graphics/png \

Thanks,
Comment 1 Matthieu Volat 2015-01-04 19:22:22 UTC
Is there any feedback on this issue?
Comment 2 Raphael Kubo da Costa freebsd_committer freebsd_triage 2015-01-04 19:49:23 UTC
I think it doesn't apply anymore: the ZEROCONF option was removed in https://svnweb.freebsd.org/ports?view=revision&revision=372093 so we always depend on Avahi (via this dependency on libavahi-core.so).
Comment 3 Matthieu Volat 2015-01-04 19:59:00 UTC
But it is possible to build kdelibs without any zeroconf support, isn't it? In that case, should not Avahi stuff should still be under an option?
Comment 4 groot 2016-07-13 16:58:42 UTC
This was fixed in

r417328 | pi | 2016-06-22 20:57:33 +0200 (Wed, 22 Jun 2016) | 22 lines

as a side-effect of that big update patch. Adding tcb to CC to close this PR.