A new version of nomacs has been released, obviously making the CMakeLists patch (or parts of it) redundant. Update attached.
Created attachment 144893 [details] Patch to 2.0.0
The update failed to build here at the configuration stage: -- checking for module 'opencv>=2.1.0' -- package 'opencv>=2.1.0' not found CMake Error at cmake/Unix.cmake:47 (find_package): By not providing "FindOpenCV.cmake" in CMAKE_MODULE_PATH this project has asked CMake to find a package configuration file provided by "OpenCV", but CMake did not find one. Could not find a package configuration file provided by "OpenCV" (requested version 2.1.0) with any of the following names: OpenCVConfig.cmake opencv-config.cmake Add the installation prefix of "OpenCV" to CMAKE_PREFIX_PATH or set "OpenCV_DIR" to a directory containing one of the above files. If "OpenCV" provides a separate development package or SDK, be sure it has been installed. Call Stack (most recent call first): CMakeLists.txt:49 (include) -- Configuring incomplete, errors occurred!
Thanks. So much about my "obviously..." statement.
Created attachment 144922 [details] Patch to 2.0.0
-- Found OpenCVCore: /usr/local/lib/libopencv_core.so;/usr/local/lib/libopencv_imgproc.so CMake Error at cmake/Unix.cmake:55 (message): OpenCV is mandotory when enabling RAW. You have to enable ENABLE_OPENCV Call Stack (most recent call first): CMakeLists.txt:49 (include) -- Configuring incomplete, errors occurred! See also "/wrkdirs/usr/ports/graphics/nomacs/work/nomacs-2.0.0/CMakeFiles/CMakeOutput.log". *** Error code 1
Created attachment 144934 [details] (update)
Erm, are you even testing your patch before submitting it? :-) ===> Performing in-source build /bin/mkdir -p /wrkdirs/usr/ports/graphics/nomacs/work/nomacs-2.0.0 Parse error in command line argument: -DENABLE_OPENCV Should be: VAR:type=value CMake Error: No cmake script provided. CMake Error: Problem processing arguments. Aborting. Please try your update in redports (or locally with Poudriere), otherwise we risk being in this cycle of me remotely trying your patch forever.
I do, but I sometimes don't just check all options. Redports is building what I'd assume to be a "working patch"... (Forgot about Redports actually existing, I had an account there. Time to reenable it.)
Created attachment 144941 [details] (update)
redports doesn't seem to use libraries where applicable, does it? At least it spits C++ errors (not finding LibRaw) although it seems to include it. I'm officially stupid now.
Created attachment 145612 [details] Proposed Unix.cmake patch OK, I finally had some time to look at this. The LibRaw problems come from the way you've patched cmake/Unix.cmake -- you've changed the add_definitions() call and now CMake passes -DENABLE_OPENCV instead of -DWITH_OPENCV to the compiler, but the rest of the code still checks for WITH_OPENCV. This means you're making the build system enable OpenCV support while the code is built with it disabled. This attachment contains a less intrusive patch to Unix.cmake that fixes the build issues. Now you have to fix the port's plist, but that should be easy. Last but not least, it looks like the most recent version of Nomacs is now 2.0.2, you might want to upgrade to that one instead.
> OK, I finally had some time to look at this. The LibRaw problems come from > the way you've patched cmake/Unix.cmake -- you've changed the > add_definitions() call and now CMake passes -DENABLE_OPENCV instead of > -DWITH_OPENCV to the compiler, but the rest of the code still checks for > WITH_OPENCV. This means you're making the build system enable OpenCV support > while the code is built with it disabled. Oops! :-/ Sorry. > Now you have to fix the port's plist, but that should be easy. In fact, currently some of the dependencies fail to build for me, so I actually can't make a new plist right now: qt-everywhere-opensource-src-4.8.6/src/xmlpatterns leads to: > c++: error: unable to execute command: Killed > c++: error: clang frontend command failed due to signal (use -v to see invocation) Hm. > Last but not least, it looks like the most recent version of Nomacs is now > 2.0.2, you might want to upgrade to that one instead. Yes, thank you.
Created attachment 145999 [details] hm..
Well, it still fails to find exiv2 now. I'm lost. :/
this isn't patch ready apparently, even now. Moving to "in-discussion" while it's getting fixed.
cherry picking
Created attachment 150223 [details] Patch to update nomacs to 2.2.0
Hi all, I submit a patch to update nomacs to 2.2.0 (the latest version). I did a quick test of the built package with success ( just show few pictures, activate panels, ...) Remarks : - I didn't found a jpeg support neither in the makefile or the code Please test it and give me a feedback asap BTW, I need maintainer approval to commit a final patch. http://www.bebik.net/poudriere/2014-12-05_09h37m33s/logs/nomacs-2.2.0.log
(In reply to Rodrigo Osorio from comment #18) > BTW, I need maintainer approval to commit a final patch. While I'm in the process of writing my thesis (sorry - completely out of business unless it's done), I'm happy to see anyone contributing to finally making things work here. :-) Regards.
A commit references this bug: Author: rodrigo Date: Mon Dec 8 12:48:22 UTC 2014 New revision: 374261 URL: https://svnweb.freebsd.org/changeset/ports/374261 Log: Upgrade to release 2.2.0 PR: ports/192046 Submitted by: rodrigo Changes: head/graphics/nomacs/Makefile head/graphics/nomacs/distinfo head/graphics/nomacs/files/patch-CMakeLists.txt head/graphics/nomacs/files/patch-cmake_Unix.cmake head/graphics/nomacs/files/patch-cmake_UnixBuildTarget.cmake head/graphics/nomacs/pkg-plist
committed, thanks
Re-open, this fails to build on 10.1 and head
A commit references this bug: Author: rakuco Date: Mon Dec 8 23:05:57 UTC 2014 New revision: 374340 URL: https://svnweb.freebsd.org/changeset/ports/374340 Log: Fix problems introduced in r374261. * Fix the plist. * Add patch to properly look for and link against pthreads, required by the bundled webp copy used by the port (this fixes the build on FreeBSD >= 10). Ideally, we should just use webp from ports instead. PR: 192046 Changes: head/graphics/nomacs/Makefile head/graphics/nomacs/files/patch-cmake_Unix.cmake head/graphics/nomacs/files/patch-cmake_UnixBuildTarget.cmake head/graphics/nomacs/pkg-plist
My commit should fix the build problems, and also the plist. Rodrigo, did you run `make check-plist' before committing? Those plist errors were quite easy to spot...
I did a poudriere build in 10.0-RELEASE http://www.bebik.net/poudriere/latest/logs/nomacs-2.2.0.log
In fact I did a full test, build, package, install and run, see some pics without issue in a 10-RELEASE. You can make the changes if you think you have a fix but be careful doing changes if you didn't run the app you build. regards
looks good to me, thanks
(In reply to Rodrigo Osorio from comment #25) > I did a poudriere build in 10.0-RELEASE > > http://www.bebik.net/poudriere/latest/logs/nomacs-2.2.0.log When the log was available, it did not include the stage-qa and check-plist stages. Did you run either 'poudriere bulk -t' or 'poudriere testport'?