Bug 192120 - [maintainer update] comms/qpage staging support
Summary: [maintainer update] comms/qpage staging support
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
: 192122 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-07-25 20:49 UTC by jfb
Modified: 2014-07-27 12:41 UTC (History)
1 user (show)

See Also:

Attachments
patch to add staging support to comms/qpage (1.97 KB, patch)
2014-07-25 20:54 UTC, jfb 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description jfb 2014-07-25 20:49:00 UTC 
Please apply the attached diff to stage comms/qpage and un-deprecate the port.

Thanks!
Comment 1 jfb 2014-07-25 20:53:27 UTC 
*** Bug 192122 has been marked as a duplicate of this bug. ***
Comment 2 jfb 2014-07-25 20:54:44 UTC 
Created attachment 144982 [details]
patch to add staging support to comms/qpage

reattaching diff--seems like it didn't get attached when I originally submitted.
Comment 3 John Marino freebsd_committer freebsd_triage 2014-07-27 12:06:04 UTC 
this doesn't pass "make check-plist" and it's not using @sample keyword.  If I can fix this quickly I will.
Comment 4 John Marino freebsd_committer freebsd_triage 2014-07-27 12:14:56 UTC 
I don't understand this configure file logic.

I'd think "/usr/local/etc/qpage.cf" would be the real configure file and "/usr/local/etc/qpage-example.cf" is the sample file, but the code is treating "/usr/local/etc/qpage-example.cf" as the real configure file (in other words checking for its' existence as if it holds information that can't be overwritten).

That is definitely not standard.
Comment 5 John Marino freebsd_committer freebsd_triage 2014-07-27 12:16:57 UTC 
The patches look at gpage.cf is the "real" configure file so I don't know what the deal with the example is.

I'm going to change this to qpage.conf so that we can use the standard @sample keyword.
Comment 6 commit-hook freebsd_committer freebsd_triage 2014-07-27 12:38:50 UTC 
A commit references this bug:

Author: marino
Date: Sun Jul 27 12:38:43 UTC 2014
New revision: 363056
URL: http://svnweb.freebsd.org/changeset/ports/363056

Log:
  Stage comms/qpage

  The PR wasn't quite right with regards to stage support, so I had to modify
  it further.  The post-install configure file handling was focused on the
  wrong file.  I updated the default name of the qpage configure file in
  order to use the @sample keyword.  I added an entry in UPDATING to let
  users know they may need to move an existing configure file accordingly.

  PR:		192120
  Submitted by:	maintainer (Jeff Blank)
  Changes by:	marino

Changes:
  head/UPDATING
  head/comms/qpage/Makefile
  head/comms/qpage/files/patch-config.h.in
  head/comms/qpage/files/patch-config.input
  head/comms/qpage/files/patch-qpage.man
  head/comms/qpage/pkg-plist
Comment 7 John Marino freebsd_committer freebsd_triage 2014-07-27 12:41:04 UTC 
Hopefully the change in default location of the configuration file isn't too obnoxious but it really helps the port be cleaner by allowing @sample keyword to be used.  I added an entry to UPDATING to note the change.

It passed the basic quality checks now.