Created attachment 144985 [details]
Patch to add STAGE support
Add STAGE support. Also a few compilation fixes for 10.x.
Tested with "poudriere testport"
Do you know why it requires a setuid file zmfix ?
A commit references this bug:
Date: Sat Jul 26 20:06:42 UTC 2014
New revision: 362985
multimedia/zoneminder: STAGE support and compilation fixes for 10.x.
Submitted by: firstname.lastname@example.org (G. Paul Ziemba)
Would you be willing to become the official maintainer for that port ?
And: can You find out why files/patch-src_zm_event.cpp has ^M-characters ?
Can you try to get those fixed upstream ?
Can you also test on HEAD ?
It still fails to build there:
The errors in the log from HEAD look like the same missing "#include <unistd.h>" sorts of errors I fixed for 10.x. It will take me a few days to set up a HEAD vm (have to download + interleave with other work) but I might be able to produce a patch just by logfile inspection in the meantime.
My only familiarity with zoneminder is as a user for about eight months, sooo... yes, I am willing to take on maintainership if nobody else wants it (one-eyed man in the land of the blind, etc.)
Don't know why zmfix needs to be setuid; will investigate as time permits.
Weird about the ^Ms in zm_event.cpp. Will see if they are still present in 1.27 and pester upstream if so.
Zoneminder port 1.25.0_3 could compile with graphics/libjpeg-turbo. Port 1.25.0_4 seems to explicitely require graphics/libjpeg. Is it possible to omit graphics/libjpeg again when graphics/libjpeg-turbo is already installed? (Or better yet, prefer graphics/libjpeg-turbo in make.conf?)
Thanks for the pointer to libjpeg-turbo. I don't know how to achieve this (preference of -turbo over the generic one), and I'll ask around. Any hint is very much appreciated!
(In reply to Kurt Jaeger from comment #8)
> Thanks for the pointer to libjpeg-turbo. I don't know how to achieve this
> (preference of -turbo over the generic one), and I'll ask around. Any hint
> is very much appreciated!
I actually don't have the answer either. As a short-term hack, I edited the Makefile to point to "graphics/libjpeg-turbo", compiled, and am running now without any issue.
(In reply to Kurt Jaeger from comment #5)
> Can you also test on HEAD ?
> It still fails to build there:
It looks as if files/patch-src_zm_thread.h (part of the patch I submitted) did not get committed.
(In reply to Kurt Jaeger from comment #4)
> And: can You find out why files/patch-src_zm_event.cpp has ^M-characters ?
> Can you try to get those fixed upstream ?
Just checked ZoneMinder-1.27.0. src/zm_event.cpp in that version does not have ^Ms
A commit references this bug:
Date: Sat Aug 2 09:10:34 UTC 2014
New revision: 363800
multimedia/zoneminder: add missing files/patch-src_zm_thread.h
patch-src_zm_thread.h fixes the break on HEAD
Submitted by: email@example.com
Added the missing file, sorry about that.
Are you planing to provide an update to 1.27 ? And becoming the maintainer 8-) ?
(In reply to Kurt Jaeger from comment #13)
> Are you planing to provide an update to 1.27 ? And becoming the maintainer
> 8-) ?
I see in <a href=https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=190268>bug 190268</a> that pakhom is working on 1.27 and has requested maintainership, so I'll stand back.
This looks finished to me.