Bug 192126 - [maintainer] games/frogatto: Fix build with clang (9.x - 11.x)
Summary: [maintainer] games/frogatto: Fix build with clang (9.x - 11.x)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-26 05:47 UTC by fiziologus
Modified: 2014-07-28 21:17 UTC (History)
2 users (show)

See Also:


Attachments
fix for clang (701 bytes, patch)
2014-07-26 05:47 UTC, fiziologus
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description fiziologus 2014-07-26 05:47:30 UTC
Created attachment 144989 [details]
fix for clang

dante@ tested youself commit only with gcc, but clang rise more warnings.

Patch remove -Werror flag, change -lpthred to PTHREAD_LIBS and adding some nocritical depends note.
Comment 1 John Marino freebsd_committer 2014-07-26 06:53:02 UTC
fix title and CC danfe@
Comment 2 commit-hook freebsd_committer 2014-07-28 21:15:13 UTC
A commit references this bug:

Author: marino
Date: Mon Jul 28 21:14:44 UTC 2014
New revision: 363257
URL: http://svnweb.freebsd.org/changeset/ports/363257

Log:
  games/frogatto: Attempt to unbreak

  Portsmon says this is broken everywhere.  Maybe this untested PR
  from the maintainer will fix it.

  PR:		192126
  Submitted by:	maintainer (Green Dog)

Changes:
  head/games/frogatto/Makefile
Comment 3 John Marino freebsd_committer 2014-07-28 21:17:08 UTC
I left off the pkgconfig => pkgconfig:build change since it had no net effect. :build is the default.

I also revbumped it as the title implies it builds on FreeBSD 8.

I don't get the clang / FreeBSD 9 reference.

My machine is tied up so I couldn't test the patch.  As it's broken just about everywhere, adding the patch can't make it worse so let's hope it's a good one!