Created attachment 145000 [details] tcc.diff - Clean-up Makefile - Add INFO macro - Fix pkg-plist - Bump PORTREVISION
Build log: https://redports.org/buildarchive/20140726161932-16432/ Despite the error on 11-CURRENT/i386. I tested it on my machine and it installs fine. http://pastebin.com/bXfcAMfP # 11-CURRENT/i386
I think you should state if "tested it on my machine" if "my machine" equals "FreeBSD 11 i386" and if "tested it" means installed locally or properly using poudriere... Setting to "patch-ready" but you (Carlos) should answer those questions for the person that picks up the PR.
(In reply to John Marino from comment #2) > I think you should state if "tested it on my machine" if "my machine" equals > "FreeBSD 11 i386" and if "tested it" means installed locally or properly > using poudriere... > > Setting to "patch-ready" but you (Carlos) should answer those questions for > the person that picks up the PR. Yes, I installed it locally. If you need more details, please ask me.
so local installs are not really worth much. IOW you say you installed it locally, but that doesn't trump a redports failure. Now if it passes a poudriere testpoint on FreeBSD 11 i386, that would trump a redports failure.
Ok, I will prepare the environment to perform a test with poudriere. Currently I don't have it installed neither tinderbox.
Meanwhile to advance, please can you test it? I'll return the favor.
I'm just the triage guy, I was only prepping you for the real committer. :)
(In reply to John Marino from comment #7) > I'm just the triage guy, I was only prepping you for the real committer. :) Thanks mate :)
A commit references this bug: Author: madpilot Date: Tue Jul 29 14:33:18 UTC 2014 New revision: 363329 URL: http://svnweb.freebsd.org/changeset/ports/363329 Log: - Fix plist - Add INFO macro and USES=makeinfo to make it also work on revent head - Clean up Makefile PR: 192137 Submitted by: Carlos Jacobo Puga Medina <cjpugmed@gmail.com> (maintainer) Changes: head/lang/tcc/Makefile head/lang/tcc/pkg-plist
(In reply to commit-hook from comment #9) > A commit references this bug: > > Author: madpilot > Date: Tue Jul 29 14:33:18 UTC 2014 > New revision: 363329 > URL: http://svnweb.freebsd.org/changeset/ports/363329 > > Log: > - Fix plist > - Add INFO macro and USES=makeinfo to make it also work on revent head The USES macro is what fixed your build error on head. makeinfo has been recently removed from FreeBSD, that macro takes care of checking if it's available or adding a dependency on the relevant port. I took the freedom to directly commit this one. Thanks for your submission!
(In reply to Guido Falsi from comment #10) > (In reply to commit-hook from comment #9) > > A commit references this bug: > > > > Author: madpilot > > Date: Tue Jul 29 14:33:18 UTC 2014 > > New revision: 363329 > > URL: http://svnweb.freebsd.org/changeset/ports/363329 > > > > Log: > > - Fix plist > > - Add INFO macro and USES=makeinfo to make it also work on revent head > > The USES macro is what fixed your build error on head. > > makeinfo has been recently removed from FreeBSD, that macro takes care of > checking if it's available or adding a dependency on the relevant port. > > I took the freedom to directly commit this one. > > Thanks for your submission! Thanks. I didn't realize it, therefore, I forgot to add USE=makeinfo.