Revision 361618 added this rule among others:
* Check to make sure patch file names contain no more than 100 characters.
I believe the rule wants the filename of the patch to be less than 100 characters, but the check is counting the entire path.
> cd /usr/ports/deskutils/cairo-dock-plugins
(only warnings seen)
but then when the ports tree is in a non-standard location:
root@Niner:~ # cd /home/marino/svnhub/freebsd-ports/deskutils/cairo-dock-plugins/
root@Niner:/home/marino/svnhub/freebsd-ports/deskutils/cairo-dock-plugins # portlint
WARN: Makefile: TERMINAL appears in PORT_OPTIONS:M, but is not listed in OPTIONS_DEFINE.
WARN: Makefile: Consider adding support for a NLS knob to conditionally disablegettext support.
WARN: Makefile: Consider defining LICENSE.
patch-Dbus__interfaces__vala__CMakeLists.txt: make sure patch file names contain
no more than 100 characters.
1 fatal error and 3 warnings found.
So that's why I think the rule is looking at the length of the entire path, and not the length of just the filename of the patch. I've seen this on a few ports now.
Hi Marcus, can you verify what I'm seeing in portlint is a bug?
I reported this to marcus@ cc demon@ then forwarded to portmgr@ with no response, so including original email below for reference to a second reproduction:
make sure patch file names contain no more than 100 characters.
is this (including characters in path-to-file) expected?
`svn status` is:
Can you try this and see if it helps:
Works for me on patch file reported in comment 2, thanks Marcus! :)
Also, ports-mgmt/portlint needs a LICENSE update (BSD -> BSD[X]CLAUSE)
same here, it now works for the cairo-dock example.
A commit references this bug:
Date: Mon Jul 28 13:21:07 UTC 2014
New revision: 363150
Update to 2.15.4.
Use File::Basename so that only the patch filename is checked for the 100
Fix has been committed. Thanks for the report!