Bug 192179 - [stage][patch] comms/ncid: update to 0.89, added LICENSE & take maintainership
Summary: [stage][patch] comms/ncid: update to 0.89, added LICENSE & take maintainership
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: John Marino
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-28 00:55 UTC by Carlos J Puga Medina
Modified: 2014-07-31 21:00 UTC (History)
0 users

See Also:


Attachments
ncid-0.89.diff (7.65 KB, patch)
2014-07-28 00:55 UTC, Carlos J Puga Medina
no flags Details | Diff
ncid-0.89.diff (7.59 KB, patch)
2014-07-29 08:17 UTC, Carlos J Puga Medina
no flags Details | Diff
ncid-0.89-v1.diff (7.61 KB, patch)
2014-07-31 19:45 UTC, Carlos J Puga Medina
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos J Puga Medina 2014-07-28 00:55:53 UTC
Created attachment 145056 [details]
ncid-0.89.diff

- Update to 0.89
- Add STAGE support
- Add LICENSE & LICENSE_FILE
- Sort OPTIONS
- Fix pkg-plist
- Take maintainership
Comment 1 John Marino freebsd_committer 2014-07-28 11:54:58 UTC
I took a look at the patch, this isn't going to work.

There should not be a MANPAGES options.  MANPAGES are installed always per policy.  Can you submit a new change where manpages are unconditionally listed installed and listed in pkg-plist?
Comment 2 Carlos J Puga Medina 2014-07-29 08:17:37 UTC
Created attachment 145115 [details]
ncid-0.89.diff

Thanks for the triage. Done!
Comment 3 John Marino freebsd_committer 2014-07-31 17:51:22 UTC
I guess this wasn't poudriere tested?

========================================
gmake[2]: Entering directory `/wrkdirs/usr/ports/comms/ncid/work/ncid/man'
pod2man ../tools/cidalias.pl cidalias.1
gmake[2]: Entering directory `/wrkdirs/usr/ports/comms/ncid/work/ncid/logrotate'
sed 's,/usr/local/share,/usr/local/share,' ncid.logrotate > ncid
gmake[2]: pod2man: Command not found
gmake[2]: *** [cidalias.1] Error 127
gmake[2]: Leaving directory `/wrkdirs/usr/ports/comms/ncid/work/ncid/man'
gmake[1]: *** [mandir] Error 2
gmake[1]: *** Waiting for unfinished jobs....




It's missing at least one dependency.
Comment 4 Carlos J Puga Medina 2014-07-31 18:05:12 UTC
I'll take a look.
Comment 5 Carlos J Puga Medina 2014-07-31 19:45:34 UTC
Created attachment 145192 [details]
ncid-0.89-v1.diff

This will fix the build error:

- Add Perl as dependency for install (pod2man)

Build log:

https://redports.org/buildarchive/20140731192201-41369/

Thanks again :)
Comment 6 commit-hook freebsd_committer 2014-07-31 20:59:49 UTC
A commit references this bug:

Author: marino
Date: Thu Jul 31 20:59:13 UTC 2014
New revision: 363677
URL: http://svnweb.freebsd.org/changeset/ports/363677

Log:
  comms/ncid: Upgrade version 0.84 => 0.89 and stage

  Also identify LICENSE and assign maintainership to submitter

  PR:		192179
  Submitted by:	Carlos JPM

Changes:
  head/comms/ncid/Makefile
  head/comms/ncid/distinfo
  head/comms/ncid/pkg-plist
Comment 7 John Marino freebsd_committer 2014-07-31 21:00:50 UTC
Thanks for the quick response; poudriere liked the update!