Bug 192187 - devel/ddd has Texinfo files predating Texinfo 5
Summary: devel/ddd has Texinfo files predating Texinfo 5
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-28 12:14 UTC by Trond Endrestøl
Modified: 2014-08-19 14:41 UTC (History)
2 users (show)

See Also:


Attachments
Patch for ddd/ddd.texi (445 bytes, patch)
2014-07-28 12:16 UTC, Trond Endrestøl
no flags Details | Diff
Patch for ddd/macros.texi (1.09 KB, patch)
2014-07-28 12:16 UTC, Trond Endrestøl
no flags Details | Diff
Patch for ddd/ddd-themes.texi (467 bytes, patch)
2014-07-28 12:17 UTC, Trond Endrestøl
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Trond Endrestøl 2014-07-28 12:14:39 UTC
devel/ddd is a bit old and assumes Texinfo pre-5 when generating the info files. Attached are three patches that makes print/texinfo 5.2.20140707 happy.

devel/ddd doesn't work with clang on stable/9, stable/10, nor head, nor with USE_GCC=4.7. Using USE_GCC=any works when world was compiled and installed with WITH_GCC=yes (and possibly with WITH_GNUCXX=yes, as I have set both) in /etc/src.conf.

If you're stupid enough, like me, to set CPUTYPE?=corei7 or to a suitable value in /etc/make.conf, you'll likely run into trouble when using /usr/bin/gcc on stable/9, stable/10, and head.

Maybe the USE_GCC= logic should consider the CPUTYPE variable and either simply undefine it when resorting to use /usr/bin/gcc, or translate the variable into a value acceptable to /usr/bin/gcc. I added these lines to my devel/ddd/Makefile.local:

USE_GCC=        any

.ifdef CPUTYPE
.if ! "${CPUTYPE}" == "core2"
CPUTYPE=core2
.endif
.endif
Comment 1 Trond Endrestøl 2014-07-28 12:16:04 UTC
Created attachment 145072 [details]
Patch for ddd/ddd.texi
Comment 2 Trond Endrestøl 2014-07-28 12:16:39 UTC
Created attachment 145073 [details]
Patch for ddd/macros.texi
Comment 3 Trond Endrestøl 2014-07-28 12:17:11 UTC
Created attachment 145074 [details]
Patch for ddd/ddd-themes.texi
Comment 4 John Marino freebsd_committer freebsd_triage 2014-07-28 13:44:50 UTC
notify maintainer for approval
Comment 5 John Marino freebsd_committer freebsd_triage 2014-08-11 08:58:35 UTC
This PR timed out, maintain approval no longer required.  Anybody can commit this now.
Comment 6 John Marino freebsd_committer freebsd_triage 2014-08-19 13:02:47 UTC
(In reply to Trond.Endrestol from comment #0)
> devel/ddd is a bit old and assumes Texinfo pre-5 when generating the info
> files. Attached are three patches that makes print/texinfo 5.2.20140707
> happy.

Please, in the future, don't provide individual patches to the software.  Provide a single diff to the port itself, a diff that creates the patches and puts them in file.  Otherwise the committer has to rename these files and move them him or herself.


> 
> devel/ddd doesn't work with clang on stable/9, stable/10, nor head, nor with
> USE_GCC=4.7. Using USE_GCC=any works when world was compiled and installed
> with WITH_GCC=yes (and possibly with WITH_GNUCXX=yes, as I have set both) in
> /etc/src.conf.
> 
> If you're stupid enough, like me, to set CPUTYPE?=corei7 or to a suitable
> value in /etc/make.conf, you'll likely run into trouble when using
> /usr/bin/gcc on stable/9, stable/10, and head.
> 
> Maybe the USE_GCC= logic should consider the CPUTYPE variable and either
> simply undefine it when resorting to use /usr/bin/gcc, or translate the
> variable into a value acceptable to /usr/bin/gcc. I added these lines to my
> devel/ddd/Makefile.local:
> 
> USE_GCC=        any
> 
> .ifdef CPUTYPE
> .if ! "${CPUTYPE}" == "core2"
> CPUTYPE=core2
> .endif
> .endif


I don't know what to do with this information.  Are you saying you want to change the Makefile too?  Where's the patch for that?
Comment 7 Trond Endrestøl 2014-08-19 13:35:17 UTC
(In reply to John Marino from comment #6)
> (In reply to Trond.Endrestol from comment #0)
> > devel/ddd is a bit old and assumes Texinfo pre-5 when generating the info
> > files. Attached are three patches that makes print/texinfo 5.2.20140707
> > happy.
> 
> Please, in the future, don't provide individual patches to the software. 
> Provide a single diff to the port itself, a diff that creates the patches
> and puts them in file.  Otherwise the committer has to rename these files
> and move them him or herself.

Wilco.

> > devel/ddd doesn't work with clang on stable/9, stable/10, nor head, nor with
> > USE_GCC=4.7. Using USE_GCC=any works when world was compiled and installed
> > with WITH_GCC=yes (and possibly with WITH_GNUCXX=yes, as I have set both) in
> > /etc/src.conf.
> > 
> > If you're stupid enough, like me, to set CPUTYPE?=corei7 or to a suitable
> > value in /etc/make.conf, you'll likely run into trouble when using
> > /usr/bin/gcc on stable/9, stable/10, and head.
> > 
> > Maybe the USE_GCC= logic should consider the CPUTYPE variable and either
> > simply undefine it when resorting to use /usr/bin/gcc, or translate the
> > variable into a value acceptable to /usr/bin/gcc. I added these lines to my
> > devel/ddd/Makefile.local:
> > 
> > USE_GCC=        any
> > 
> > .ifdef CPUTYPE
> > .if ! "${CPUTYPE}" == "core2"
> > CPUTYPE=core2
> > .endif
> > .endif
> 
> 
> I don't know what to do with this information.  Are you saying you want to
> change the Makefile too?  Where's the patch for that?

There isn't any. The problem is that while corei7 is accepted by clang, the same value isn't accepted by gcc 4.2.1, nor is it translated to something accepted by gcc 4.2.1.

I gather there isn't anything to do. In the long run, gcc will eventually be replaced by clang, and software such as devel/ddd will either need a rewrite or will be removed from the ports collection.

I simply wanted to leave a trace of what I had done and how to work around it, just in case someone else trips over the same issue. Maybe that counts as a misuse of the bugzilla system.

And maybe the morale of this story is simply to avoid the use of CPUTYPE in /etc/make.conf, it sure creates a lot of hassle in my encounters.
Comment 8 John Marino freebsd_committer freebsd_triage 2014-08-19 13:40:09 UTC
(In reply to Trond.Endrestol from comment #7)
> And maybe the morale of this story is simply to avoid the use of CPUTYPE in
> /etc/make.conf, it sure creates a lot of hassle in my encounters.

That's good advice, especially for building the OS itself, much less the problems it causes in ports.
Comment 9 Antoine Brodin freebsd_committer freebsd_triage 2014-08-19 14:41:57 UTC
Another patch has been committed in r364155,  which fixes build with clang and new texinfo