Bug 192260 - net/relayd marked broken. "Abuse evbuffer API"
Summary: net/relayd marked broken. "Abuse evbuffer API"
Status: Closed Feedback Timeout
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Martin Matuska
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-29 23:46 UTC by robert zelaya
Modified: 2014-11-02 23:25 UTC (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description robert zelaya 2014-07-29 23:46:18 UTC 
Relayd marked as broken.
Aggressive checks when just doing Layer 7 forwarding.

Issues.

1) "Abuse of evbuffer API" after libevent1 -> libevent2 migration."

2) "Relayd does not start when ipv6 address is not present."

3) "Relayd checks for "/dev/pf" when only doing layer 7 relaying."
Comment 1 John Marino freebsd_committer freebsd_triage 2014-07-30 07:36:56 UTC 
I don't understand the purpose of this PR.

1) "Relayd marked as broken.", this states a known fact
2) lists 3 issues --- and?
3) There's no patch provided

So what do you want this PR to accomplish?  It's not clear from either the title or the comment.
Comment 2 John Marino freebsd_committer freebsd_triage 2014-07-30 07:38:04 UTC 
There is, however, a maintainer for this port so I'll let him try to decipher this message.  (I see he was already CC'd)
Comment 3 Martin Matuska freebsd_committer freebsd_triage 2014-07-30 11:03:55 UTC 
To interpret this:
- relayd was never updated for libevent2
- I want to make as few changes to upstream as possible
- I guess bundling static libevent1 might do the trick for starters ;-)
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2014-07-30 12:31:53 UTC 
mm@, I concur with your translation: "Fix relayd, broken by libevent1 -> libevent2 migration"

Rob, issues (2) and (3) are better off as individual reports, to improve time to resolution for each, as well as isolated commits.
Comment 5 robert zelaya 2014-07-30 15:47:28 UTC 
(In reply to Kubilay Kocak from comment #4)
> mm@, I concur with your translation: "Fix relayd, broken by libevent1 ->
> libevent2 migration"
> 
> Rob, issues (2) and (3) are better off as individual reports, to improve
> time to resolution for each, as well as isolated commits.

Ill make bug reports for the 2 issues I stated.

Thanks for all the help.
Comment 6 commit-hook freebsd_committer freebsd_triage 2014-08-04 19:55:55 UTC 
A commit references this bug:

Author: mm
Date: Mon Aug  4 19:55:53 UTC 2014
New revision: 364044
URL: http://svnweb.freebsd.org/changeset/ports/364044

Log:
  Update relayd to 5.5.20140730

  PR:		192260

Changes:
  head/net/relayd/Makefile
  head/net/relayd/distinfo
Comment 7 Martin Matuska freebsd_committer freebsd_triage 2014-08-04 20:00:01 UTC 
I have bundled libevent 1.4 with relayd and updated with more recent code.