Bug 192404 - [EXP-RUN] Pull in linux-c6 compat layer
Summary: [EXP-RUN] Pull in linux-c6 compat layer
Status: Closed DUPLICATE of bug 187786
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Many People
Assignee: Bryan Drewery
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-05 17:42 UTC by Sean Bruno
Modified: 2014-09-18 15:34 UTC (History)
1 user (show)

See Also:
sbruno: exp-run?


Attachments
Complete and suggested patch to ports tree based on xmj's work (687.48 KB, application/x-gzip)
2014-08-05 17:51 UTC, Sean Bruno
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sean Bruno freebsd_committer freebsd_triage 2014-08-05 17:42:08 UTC
Took an hour or two today in an attempt to look over the linux-c6
| changes at:  https://github.com/xmj/linux-ports
| 
| I've pulled them all in on redports:
| https://redports.org/changeset/30034/sbruno
| https://redports.org/changeset/30035/sbruno
| 
| Right now, I can't do much with them.  I need to adjust the linux compat
| tuneable to 2.6.18.
| 
| I can trivially bump the compat revision in
| head/sys/compat/linux/linux_mib.c but I'm not sure if this is what we
| want to do.
| 
| How do you folks want to proceed with this import?
Comment 1 Sean Bruno freebsd_committer freebsd_triage 2014-08-05 17:51:03 UTC
Created attachment 145399 [details]
Complete and suggested patch to ports tree based on xmj's work

For an exp run, the compat.linux.osrelease needs to be bumped to 2.6.18, this is a runtime configureable tuneable, so feel free to modify the build jail to do this:

compat.linux.osrelease: 2.6.16

compat.linux.osrelease: 2.6.18

I have no idea if any of this works at all as I cannot reliably test builds in redports with this patch. 

This patch applies cleanly to ports head at svn revision 364125
Comment 2 Carlos J Puga Medina 2014-08-05 18:28:30 UTC
Take a look as reference this thread posted in the FreeBSD Forums:
http://forums.freebsd.org/viewtopic.php?f=22&t=44800

It was time to commit this update into the ports tree :)
Comment 3 Sean Bruno freebsd_committer freebsd_triage 2014-08-05 19:07:59 UTC
I think this may be required once this hits the tree:

Index: sys/compat/linux/linux_mib.c
===================================================================
--- sys/compat/linux/linux_mib.c	(revision 269592)
+++ sys/compat/linux/linux_mib.c	(working copy)
@@ -129,9 +129,9 @@
 
 static struct linux_prison lprison0 = {
 	.pr_osname =		"Linux",
-	.pr_osrelease =		"2.6.16",
+	.pr_osrelease =		"2.6.18",
 	.pr_oss_version =	0x030600,
-	.pr_osrel =		2006016
+	.pr_osrel =		2006018
 };
Comment 4 Carlos J Puga Medina 2014-08-05 19:24:25 UTC
(In reply to Sean Bruno from comment #3)
> I think this may be required once this hits the tree:
> 
> Index: sys/compat/linux/linux_mib.c
> ===================================================================
> --- sys/compat/linux/linux_mib.c	(revision 269592)
> +++ sys/compat/linux/linux_mib.c	(working copy)
> @@ -129,9 +129,9 @@
>  
>  static struct linux_prison lprison0 = {
>  	.pr_osname =		"Linux",
> -	.pr_osrelease =		"2.6.16",
> +	.pr_osrelease =		"2.6.18",
>  	.pr_oss_version =	0x030600,
> -	.pr_osrel =		2006016
> +	.pr_osrel =		2006018
>  };

Yes, with this change we don't need anymore tweak 'compat.linux.osrelease' in /etc/sysctl.conf
Comment 5 John Marino freebsd_committer freebsd_triage 2014-08-05 20:57:39 UTC
is this really "ports tree" product?  seems like base to me.  Do one of you want to reclassify this PR?
Comment 6 Carlos J Puga Medina 2014-08-05 22:04:47 UTC
Yes, we are talking about the full Lin­ux­u­la­tor infra­struc­ture based upon CentOS 6.5 for the ports collection which has some more ports around a linux_base port. 

Anyway, I have no permission to modify it :)
Comment 7 Sean Bruno freebsd_committer freebsd_triage 2014-08-05 22:49:18 UTC
(In reply to John Marino from comment #5)
> is this really "ports tree" product?  seems like base to me.  Do one of you
> want to reclassify this PR?

No, IMO.

Only a very small part (2.6.16 -> 2.6.18) seems to be directly applicable to src.  

The zipped patch file is quite huge and applies almost exclusively to the ports tree.
Comment 8 John Marino freebsd_committer freebsd_triage 2014-08-06 06:19:49 UTC
How do you propose a ports committer make the src change?  The majority don't have permission to commit to src.

At the least you are looking at a second PR for src that blocks this one.
Comment 9 John Marino freebsd_committer freebsd_triage 2014-08-06 06:30:04 UTC
actually it seems that the src part is blocked by the first part and it doesn't seem strictly mandatory.
Comment 10 John Marino freebsd_committer freebsd_triage 2014-08-06 15:17:03 UTC
Bryan,
Sean told me via IRC to assign this to you.  He can take care of the src part.  I'm bowing out now.
Comment 11 Sean Bruno freebsd_committer freebsd_triage 2014-09-18 15:34:03 UTC
Marking this as resolved for now as we have a much more better version of this patch in the queue to be committed by someone who is not me.  :-)

*** This bug has been marked as a duplicate of bug 187786 ***