Bug 192531 - [stage] Update Port: net/wackford-squeers to 1.19
Summary: [stage] Update Port: net/wackford-squeers to 1.19
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: John Marino
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-09 17:42 UTC by jimmy
Modified: 2014-08-10 18:21 UTC (History)
1 user (show)

See Also:

Attachments
diff -ruN attached (1.53 KB, patch)
2014-08-09 17:42 UTC, jimmy 		no flags Details | Diff
diff -ruN (860 bytes, patch)
2014-08-09 23:32 UTC, jimmy 		no flags Details | Diff
poudriere testport am64 (11.86 KB, text/plain)
2014-08-09 23:34 UTC, jimmy 		no flags Details
poudriere testport i386 (12.65 KB, text/plain)
2014-08-09 23:34 UTC, jimmy 		no flags Details
diff -ruN (719 bytes, patch)
2014-08-10 14:43 UTC, jimmy 		no flags Details | Diff
diff -ruN (1.54 KB, patch)
2014-08-10 16:10 UTC, jimmy 		no flags Details | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description jimmy 2014-08-09 17:42:24 UTC 
Created attachment 145576 [details]
diff -ruN attached

New version has been released.

Port has been converted to use staging.

Diff attached.
Comment 1 John Marino freebsd_committer freebsd_triage 2014-08-09 22:17:04 UTC 
I normally require proof (e.g. redports or poudriere logs) on staging PRs that it actually works.

I'll take a chance and declare this "patch-ready" because the changes look minimal.  Still, if you get a chance, run "make clean ; make check-plist ; make stage-qa" and make sure it's probably good.
Comment 2 jimmy 2014-08-09 23:32:33 UTC 
Created attachment 145589 [details]
diff -ruN
Comment 3 jimmy 2014-08-09 23:34:23 UTC 
Created attachment 145590 [details]
poudriere testport am64
Comment 4 jimmy 2014-08-09 23:34:57 UTC 
Created attachment 145591 [details]
poudriere testport i386
Comment 5 jimmy 2014-08-09 23:35:40 UTC 
Fresh diff. Removed MANCOMPRESSED.
Comment 6 John Marino freebsd_committer freebsd_triage 2014-08-10 13:07:57 UTC 
(In reply to jimmy from comment #5)
> Fresh diff. Removed MANCOMPRESSED.

I think there's been a mistake.

There are two attachments on this PR, each do something something (rather than one being set to "obsolete") and neither remove MANCOMPRESSED.  Can you take a look again?
Comment 7 jimmy 2014-08-10 14:43:07 UTC 
Created attachment 145610 [details]
diff -ruN
Comment 8 jimmy 2014-08-10 14:45:31 UTC 
New diff obsoletes others. For the first patch, I was working from an old copy of portdir from before I installed poudriere. In the meantime, someone had staged the port and removed MANCOMPRESSED.
Comment 9 John Marino freebsd_committer freebsd_triage 2014-08-10 14:58:02 UTC 
okay, that would explain it, thanks
Comment 10 John Marino freebsd_committer freebsd_triage 2014-08-10 15:27:58 UTC 
(In reply to jimmy from comment #8)
> New diff obsoletes others. For the first patch, I was working from an old
> copy of portdir from before I installed poudriere. In the meantime, someone
> had staged the port and removed MANCOMPRESSED.

The patch didn't apply cleanly.  I checked the latest version and nobody staged it; nobody removed MANCOMPRESSED.

see: http://svnweb.freebsd.org/ports/head/net/wackford-squeers/Makefile?revision=362812&view=markup

So I think there is some confusion somewhere.
Comment 11 jimmy 2014-08-10 16:10:13 UTC 
Created attachment 145611 [details]
diff -ruN

I must have patched my ports tree by mistake. Did a portsnap extract and generated another diff.
Comment 12 jimmy 2014-08-10 16:11:05 UTC 
Thomas Abthorpe did stage some of my ports thus the confusion.
Comment 13 commit-hook freebsd_committer freebsd_triage 2014-08-10 18:20:06 UTC 
A commit references this bug:

Author: marino
Date: Sun Aug 10 18:19:37 UTC 2014
New revision: 364555
URL: http://svnweb.freebsd.org/changeset/ports/364555

Log:
  net/wackford-squeers: Update version 1.17 => 1.19 and stage

  PR:		192531
  Submitted by:	James Bailie

Changes:
  head/net/wackford-squeers/Makefile
  head/net/wackford-squeers/distinfo
  head/net/wackford-squeers/pkg-plist
Comment 14 John Marino freebsd_committer freebsd_triage 2014-08-10 18:21:32 UTC 
I'm glad it's finally resolved. :)