Bug 192540 - Made port config dialog more informative: show overidden flag and non-default selection flag
Summary: Made port config dialog more informative: show overidden flag and non-default...
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-09 22:52 UTC by Yuri Victorovich
Modified: 2018-01-13 22:32 UTC (History)
2 users (show)

See Also:


Attachments
patch to Mk (1.37 KB, patch)
2014-08-09 22:53 UTC, Yuri Victorovich
no flags Details | Diff
patch to ports-mgmt/dialog4ports (3.84 KB, patch)
2014-08-09 22:53 UTC, Yuri Victorovich
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer 2014-08-09 22:52:38 UTC
The attached patches make config dialog show two additional bits of information per option:

(a) The option was globally overridden in /etc/make.conf using OPTIONS_SET/OPTIONS_UNSET. This is shown as a gray symbol 'o' near the option
(b) The option selection is different from default. This is shown with the red color of the check.

There  are two patches: one into Mk and one into ports-mgmt/dialog4ports port.
Comment 1 Yuri Victorovich freebsd_committer 2014-08-09 22:53:07 UTC
Created attachment 145584 [details]
patch to Mk
Comment 2 Yuri Victorovich freebsd_committer 2014-08-09 22:53:37 UTC
Created attachment 145585 [details]
patch to ports-mgmt/dialog4ports
Comment 3 John Marino freebsd_committer 2014-08-09 23:17:46 UTC
I guess we get the port approved first, so CC Maintainer
Comment 4 John Marino freebsd_committer 2014-08-22 17:46:46 UTC
I don't know what happened, the maintainer was never added to the CC list.  Sorry, Adding him now but we just lost two weeks.  Hopefully he responds quickly.
Comment 5 m1cro 2014-08-22 20:38:48 UTC
Sorry for delay, just give me few days on review(was in vacation).
Comment 6 John Marino freebsd_committer 2014-08-22 20:40:16 UTC
sure.  The delay was my fault, not yours.
Comment 7 John Marino freebsd_committer 2014-09-20 17:56:36 UTC
rum1cro: okay, an additional month has passed, so this has definitely timed out.  Bapt already took the PR though.
Comment 8 Yuri Victorovich freebsd_committer 2018-01-13 22:32:21 UTC
I'll revamp this patch.