Created attachment 145626 [details] This is the SHAR archive of the port. VirtualGL is a tool that allows you to forward GLX commands to another X server, where they are rendered, and then sent back to the local X server for display. This port is being submitted primarily for use with nVIDIA Optimus (for which I have devised a solution allowing its use via VirtualGL). This port depends on misc/vgl-libjpeg-turbo, bug ID 192559. Build logs will be forthcoming.
Created attachment 145634 [details] SHAR Archive of port I have updated the SHAR archive to incorporate a few fixes. This is said to build cleanly under poudriere.
Created attachment 145636 [details] This is the SHAR archive of the port. Another updated SHAR archive. Portlint no longer registers any complaints that haven't been dealt with.
I'll move it to patch ready, but it would be nice to get those poudriere logs anyway (ref: "build logs will be forthcoming")
Created attachment 145638 [details] This is the SHAR archive of the port. And one final alteration, this cleans up the last issues on i386. With regards to build logs: I'll post them ASAP; have been relying on someone else to handle the building. I'll ask him if he can upload them for me, and will provide a link when he replies. (In reply to John Marino from comment #3) > I'll move it to patch ready, but it would be nice to get those poudriere > logs anyway (ref: "build logs will be forthcoming")
(In reply to John Marino from comment #3) > I'll move it to patch ready, but it would be nice to get those poudriere > logs anyway (ref: "build logs will be forthcoming") Please find build logs at: https://people.freebsd.org/~nox/tmp/logs/
I've split apart libjpeg-turbo for you, so this port can depend on it instead of repackaging it. That said, this port does some weird stuff. Why does it depend on libtool, automake, and autoreconf if it uses cmake? Why is it installing everything under a different PREFIX rather than putting things in the usual locations? Why have you used spaces instead of tabs after variable names in the Makefile? Please work through those issues, run the port through portlint, and submit an updated version. I know you've put a lot of work into these ports, and I'm trying to help you tighten them up so we can get it committed.
(In reply to Adam Weinberger from comment #6) > I've split apart libjpeg-turbo for you, so this port can depend on it > instead of repackaging it. > > That said, this port does some weird stuff. Why does it depend on libtool, > automake, and autoreconf if it uses cmake? Why is it installing everything > under a different PREFIX rather than putting things in the usual locations? > Why have you used spaces instead of tabs after variable names in the > Makefile? > > Please work through those issues, run the port through portlint, and submit > an updated version. > > I know you've put a lot of work into these ports, and I'm trying to help you > tighten them up so we can get it committed. Hiya, I hadn't noticed the dependencies on the GNU build suite. What I did once was build libjpeg-turbo as part of this port. I'll just clear those since they no longer apply. Likewise I hadn't noticed the spaces - perhaps my editor is doing this. As for the PREFIX, that's conditionally set as VirtualGL has to be installed under its own prefix, since its installed files will collide with other sources of libGL.so, and it expects its own prefix. I'll see if I can find a cleaner way to handle the setting of prefix - unfortunately, cmake has been proving difficult to work with. Anyway - thanks for the feedback, and I'll try and sort out these issues within an hour or two.
(In reply to David Mackay from comment #7) > As for the PREFIX, that's conditionally set as VirtualGL has to be installed > under its own prefix, since its installed files will collide with other > sources of libGL.so, and it expects its own prefix. I'll see if I can find a > cleaner way to handle the setting of prefix - unfortunately, cmake has been > proving difficult to work with. cmake can be a mystery sometimes. If it has to all live under VirtualGL that's fine. With manually setting PREFIX in the Makefile, it won't behave well on the package building clusters. Plus it makes the plist look really confusing. My recommendation is to leave PREFIX alone and then you don't have to do anything weird like @dirrm bin/lib/include. Put DOCSDIR= ${PREFIX}/VirtualGL/doc into the Makefile, then you can: plist: %%DOCSDIR%%/411.gif (etc.) Or, by redefining DOCSDIR, you can even do PORTDOCS= *
(In reply to Adam Weinberger from comment #8) > (In reply to David Mackay from comment #7) > > As for the PREFIX, that's conditionally set as VirtualGL has to be installed > > under its own prefix, since its installed files will collide with other > > sources of libGL.so, and it expects its own prefix. I'll see if I can find a > > cleaner way to handle the setting of prefix - unfortunately, cmake has been > > proving difficult to work with. > > cmake can be a mystery sometimes. If it has to all live under VirtualGL > that's fine. With manually setting PREFIX in the Makefile, it won't behave > well on the package building clusters. Plus it makes the plist look really > confusing. > > My recommendation is to leave PREFIX alone and then you don't have to do > anything weird like @dirrm bin/lib/include. > > Put > DOCSDIR= ${PREFIX}/VirtualGL/doc > into the Makefile, then you can: > > plist: > %%DOCSDIR%%/411.gif (etc.) > > > Or, by redefining DOCSDIR, you can even do > PORTDOCS= * Hiya, I'm having difficulty getting the libjpeg-turbo port to work, now. I seem to be getting 404s on its distfiles.
(In reply to David Mackay from comment #9) > (In reply to Adam Weinberger from comment #8) > > (In reply to David Mackay from comment #7) > > > As for the PREFIX, that's conditionally set as VirtualGL has to be installed > > > under its own prefix, since its installed files will collide with other > > > sources of libGL.so, and it expects its own prefix. I'll see if I can find a > > > cleaner way to handle the setting of prefix - unfortunately, cmake has been > > > proving difficult to work with. > > > > cmake can be a mystery sometimes. If it has to all live under VirtualGL > > that's fine. With manually setting PREFIX in the Makefile, it won't behave > > well on the package building clusters. Plus it makes the plist look really > > confusing. > > > > My recommendation is to leave PREFIX alone and then you don't have to do > > anything weird like @dirrm bin/lib/include. > > > > Put > > DOCSDIR= ${PREFIX}/VirtualGL/doc > > into the Makefile, then you can: > > > > plist: > > %%DOCSDIR%%/411.gif (etc.) > > > > > > Or, by redefining DOCSDIR, you can even do > > PORTDOCS= * > > Hiya, > > I'm having difficulty getting the libjpeg-turbo port to work, now. > > I seem to be getting 404s on its distfiles. Never mind this. It seems to have downloaded at last. unfortunately my internet is proving extremely unreliable right now.
Created attachment 146195 [details] This is the SHAR archive of the port. I've attached a new SHAR of the port. The PREFIX meddling is now gone, courtesy of some help from the FreeBSD KDE team. This passes portlint suggesting only that a license be defined.
Good work here. Before I commit it, can I convince you to change the category? graphics? x11? misc is a black-hole.
(In reply to Adam Weinberger from comment #12) > Good work here. Before I commit it, can I convince you to change the > category? graphics? x11? misc is a black-hole. Seeing as it's an X11-related tool, I suppose x11 would be the most appropriate category. And thanks for reviewing the port and offering me feedback. After working on this I've definitely gained a new appreciation for the work involved :)
A commit references this bug: Author: adamw Date: Sat Aug 23 22:26:36 UTC 2014 New revision: 365843 URL: http://svnweb.freebsd.org/changeset/ports/365843 Log: Add x11/virtual. VirtualGL is an open source program that redirects the 3D rendering commands from Unix and Linux OpenGL applications to 3D accelerator hardware in a dedicated server and displays the rendered output interactively to a thin client located elsewhere on the network, or locally. WWW: http://www.virtualgl.org PR: 192561 Submitted by: David Mackay Changes: head/x11/Makefile head/x11/virtualgl/ head/x11/virtualgl/Makefile head/x11/virtualgl/distinfo head/x11/virtualgl/files/ head/x11/virtualgl/files/patch-common__CMakeLists.txt head/x11/virtualgl/files/patch-server__CMakeLists.txt head/x11/virtualgl/files/patch-util__CMakeLists.txt head/x11/virtualgl/files/patch-util__rrsocket.cpp head/x11/virtualgl/pkg-descr head/x11/virtualgl/pkg-plist
Committed with a few small modifications. Good work on this! Please feel free to Cc me on any further patches.