Bug 192563 - sysutils/fusefs-encfs: May not be possible to create a file if encfs_create returns ENOSYS
Summary: sysutils/fusefs-encfs: May not be possible to create a file if encfs_create r...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-10 20:59 UTC by Olivier - interfaSys sàrl
Modified: 2014-08-13 22:17 UTC (History)
1 user (show)

See Also:


Attachments
This is a simple patch to implement encfs_create by just calling mknod then open (1.74 KB, patch)
2014-08-10 20:59 UTC, Olivier - interfaSys sàrl
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier - interfaSys sàrl 2014-08-10 20:59:42 UTC
Created attachment 145627 [details]
This is a simple patch to implement encfs_create by just calling mknod then open

I was looking at how EncFS was implemented on FreeBSD and read the recent updates made to the port.

Since the the port includes modifications added to FreeBSD 10, I'm wondering if it's subject to the same problem described here:
https://code.google.com/p/encfs/issues/detail?id=204

"Using encfs on FreeBSD 10.0 compiles okay, mounts the encrypted filesystem, and even lets you create, list and delete directories. Attempting to create a file (even with something simple like "touch") returns ENOSYS. The problem can be traced to FreeBSD 10's kernel implementation of FUSE. Older FUSE implementations could handle encfs_create being undefined, they'd fall back on calling encfs_mknod then encfs_open. In FreeBSD 10, it tries calling encfs_create which returns ENOSYS and fails to create the file."

The submitter also included a patch, attached here.

I didn't see any mention of this bug, but thought I'd mention it.
Comment 1 John Marino freebsd_committer 2014-08-10 22:12:40 UTC
There's no attachment though...

There's also no maintainer for this port either (quite common for fuse ports, actually).
Comment 2 Olivier - interfaSys sàrl 2014-08-10 22:17:34 UTC
The attachment may not have been sent by email, but it's in the bug report
https://bugs.freebsd.org/bugzilla/attachment.cgi?id=145627&action=diff

But if there is no maintainer... :D
Comment 3 John Marino freebsd_committer 2014-08-10 22:23:23 UTC
it wasn't there when I wrote that!   strange..
Comment 4 John Marino freebsd_committer 2014-08-10 22:24:50 UTC
No maintainer means nobody needs to approve it.  It can be committed by anybody starting now.  Moving to patch-ready status.
Comment 5 commit-hook freebsd_committer 2014-08-13 20:48:11 UTC
A commit references this bug:

Author: marino
Date: Wed Aug 13 20:48:03 UTC 2014
New revision: 364809
URL: http://svnweb.freebsd.org/changeset/ports/364809

Log:
  sysutils/fuse-encfs: Implement encfs_create for F10 to create file

  PR:		192563
  Submitted by:	Olivier/InterfaSys
  Approved by:	nobody; the port is unmaintained

Changes:
  head/sysutils/fusefs-encfs/Makefile
  head/sysutils/fusefs-encfs/files/patch-implement-encf_create
Comment 6 John Marino freebsd_committer 2014-08-13 20:53:15 UTC
ok done, I hope the patch is correct...  (it builds)
Comment 7 Olivier - interfaSys sàrl 2014-08-13 22:17:39 UTC
I've just tested the port on FreeBSD 9 and "make" worked (after modifying a previous patch).