Bug 192571 - [patch] audio/pavucontrol: update to 2.0
Summary: [patch] audio/pavucontrol: update to 2.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Romain Tartière
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-11 03:26 UTC by Kevin Bowling
Modified: 2015-01-04 11:54 UTC (History)
1 user (show)

See Also:

Attachments
pavucontrol 2.0 (1.16 KB, patch)
2014-08-11 03:26 UTC, Kevin Bowling 		no flags Details | Diff
Patch for update of audio/pavucontrol (9.81 KB, patch)
2014-08-20 20:38 UTC, Olivier Duchateau 		no flags Details | Diff
Patch against r373636 (5.31 KB, patch)
2015-01-03 19:04 UTC, Romain Tartière 		no flags Details | Diff
Patch fixes crash with gtkmm30 (12.32 KB, patch)
2015-01-03 22:01 UTC, Olivier Duchateau 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Bowling freebsd_committer freebsd_triage 2014-08-11 03:26:21 UTC 
Created attachment 145648 [details]
pavucontrol 2.0

From https://github.com/pcbsd/freebsd-ports/commit/3bdc08947fe55c7260428087ff9ed859d7ca0ff9 with two fixes:
* Add libsigc++ libdep
* Switch to freedesktop.org as mastersite
Comment 1 John Marino freebsd_committer freebsd_triage 2014-08-11 05:58:04 UTC 
over to maintainer...
Comment 2 Olivier Duchateau freebsd_committer freebsd_triage 2014-08-20 20:36:50 UTC 
(In reply to kevin.bowling from comment #0)
> Created attachment 145648 [details]
> pavucontrol 2.0
> 
> From
> https://github.com/pcbsd/freebsd-ports/commit/
> 3bdc08947fe55c7260428087ff9ed859d7ca0ff9 with two fixes:
> * Add libsigc++ libdep
> * Switch to freedesktop.org as mastersite

Your patch is not proper (mainly syntax).

x11-toolkits/gtkmm30 and devel/libsigc++20 are available in USE_GNOME macro (see Mk/bsd.gnome.mk file)

USE_GNOME=     glibmm libsigc++20 gtkmm30

Moreover, Pavucontrol can be build with Gtk2 or Gtk3, and locales files are not in right place.
Comment 3 Olivier Duchateau freebsd_committer freebsd_triage 2014-08-20 20:38:22 UTC 
Created attachment 146085 [details]
Patch for update of audio/pavucontrol
Comment 4 Kevin Bowling freebsd_committer freebsd_triage 2014-08-23 20:50:39 UTC 
Looks good to me
Comment 5 Romain Tartière freebsd_committer freebsd_triage 2014-08-24 18:08:18 UTC 
Hello

Unfortunately, I have not been using PulseAudio recently, and cannot test this port easily with my current setup.

Would one of you be interested in becoming the maintainer of this port ?
Comment 6 Kevin Bowling freebsd_committer freebsd_triage 2014-08-24 21:59:11 UTC 
Sure, I can do it.
Comment 7 Olivier Duchateau freebsd_committer freebsd_triage 2015-01-03 18:06:49 UTC 
Romain, patch is it fine?
Comment 8 Romain Tartière freebsd_committer freebsd_triage 2015-01-03 18:54:47 UTC 
I can't run pavucontrol build against GTK3:

> (pavucontrol:34625): Gtk-CRITICAL **: gtk_box_pack: assertion 'GTK_IS_WIDGET (child)' failed
> zsh: bus error (core dumped)  pavucontrol

I had no time to investigate this.  Do you also experience this failure?
Comment 9 Romain Tartière freebsd_committer freebsd_triage 2015-01-03 19:04:07 UTC 
Created attachment 151298 [details]
Patch against r373636
Comment 10 Olivier Duchateau freebsd_committer freebsd_triage 2015-01-03 22:01:45 UTC 
Created attachment 151306 [details]
Patch fixes crash with gtkmm30

New patch, tested with gtkmm24 and gtkmm30 without crash.
Comment 11 commit-hook freebsd_committer freebsd_triage 2015-01-04 11:53:44 UTC 
A commit references this bug:

Author: romain
Date: Sun Jan  4 11:53:24 UTC 2015
New revision: 376210
URL: https://svnweb.freebsd.org/changeset/ports/376210

Log:
  Update to 2.0

  PR:		192571
  Submitted by:	olivierd

Changes:
  head/audio/pavucontrol/Makefile
  head/audio/pavucontrol/distinfo
  head/audio/pavucontrol/files/
  head/audio/pavucontrol/files/extra-patch-src_pavucontrol.glade
  head/audio/pavucontrol/files/extra-patch-support-gtkmm-24.patch
  head/audio/pavucontrol/files/extra-patch-support-gtkmm-30.patch
  head/audio/pavucontrol/pkg-descr
  head/audio/pavucontrol/pkg-plist
Comment 12 Romain Tartière freebsd_committer freebsd_triage 2015-01-04 11:54:20 UTC 
Wonderful!  Many thanks for taking care of this!