FreeBSD Bugzilla – Bug 192597
[PATCH] net/GeoIP: geoipupdate.sh script non-functional
Last modified: 2014-08-11 20:17:08 UTC
Created attachment 145688 [details]
Patch to create %%DATADIR%% before attempting download; general overhaul.
the geoipupdate.sh script is non-functional for me on a fresh ports-based install. Apparently we need to create "%%DATADIR%%" first, and the script can also do with enhanced error checking and refactoring.
Patch attached -- the crucial point is the "mkdir -p" early, and the trap/rm -f/mv -f are to make the script more robust and ask less questions in adverse conditions.
A commit references this bug:
Date: Mon Aug 11 20:16:29 UTC 2014
New revision: 364652
Ensure that DATADIR exists before attempting to fetch the data files
into it. Also, make the script more robust and ask fewer questions in
Submitted by: mandree
Awesome work. Thank you!!