Created attachment 145750 [details]
Light-weight, simple and fast XML parser for C++ with XPath support
1) no tab aligment
2) pkg-plist is too short, move files to Makefile with PLIST_FILES, etc
3) Do you have any verification available? In order of preference, examples of what I'm looking for are:
1) "poudriere testport" or "poudriere bulk -t" logs
2) Redports or tinderbox logs
3) "make check-plist" followed by "make stage-qa" output (https://www.freebsd.org/doc/en/books/porters-handbook/porting-testing.html)
Also, please run "portlint" and paste the output.
This will stay in triage state until a new version is submitted and verification provided, fyi.
Non-responsive, moving this out of Triage into General Population.
A commit references this bug:
Date: Thu Aug 21 19:07:49 UTC 2014
New revision: 365584
pugixml is a light-weight C++ XML processing library. It features:
* DOM-like interface with rich traversal/modification capabilities
* Extremely fast non-validating XML parser which constructs the DOM tree from an
* XPath 1.0 implementation for complex data-driven tree queries
* Full Unicode support with Unicode interface variants and automatic encoding
Submitted by: firstname.lastname@example.org
I've committed the port, and fixed for you the problems that John already noted.
Why does it install only a static library? Shouldn't it build and install both?
First, thank you both very much for your prompt responses. John was right, I had to test it better. Let me say to my defense that I followed the "Quick Porting" guide closely, but it mentions using poudriere and tinderbox as a "may", not a "must". Nor it mentions attaching any of the logs to the PR. I did run portlint though, and it said "seems ok" or something like that. Anyway, I went installing poudriere, it did not work out-of-the-box, and I had no time to dig it since. So I apologize for not responding.
Adam: thank you for fixing that, and the MASTER_SITES url too. As per static/dynamic libraries: I just installed whatever the library builds by default. I want to build the shared libraries too. Given the current build scripts I have to invoke cmake and make twice, or patch the scripts. What's the most correct way of doing this in ports? (This is my first time porting, as you see.)
Created attachment 146175 [details]
Builds shared and static libs
Yakov, give this patch a try.
Also I should note, due to a bug in our Bugzilla, you can't view the patch with the "Diff" link. Download the actual raw patch (click on "Builds shared and static libs") and then view it.
Tried it, the patch works for me.
Should I commit it?
Yes. Thank you very much!