Bug 192661 - [PATCH] net/freeradius: Remove build vs runtime ssl version check
Summary: [PATCH] net/freeradius: Remove build vs runtime ssl version check
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Some People
Assignee: Ryan Steinmetz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-14 18:11 UTC by Mathieu Arnold
Modified: 2014-08-16 20:19 UTC (History)
0 users

See Also:


Attachments
freeradius-2.2.5.patch (1.76 KB, patch)
2014-08-14 18:11 UTC, Mathieu Arnold
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mathieu Arnold freebsd_committer 2014-08-14 18:11:08 UTC
Created attachment 145785 [details]
freeradius-2.2.5.patch

When OpenSSL is updated, poudriere will rebuild both OpenSSL and freeradius but
if the .so version number did not change, pkg will not reinstall freeradius and
then freeradius will be broken.

So, remove the check, it doesn't really serve any purpose I can think of.

Generated with FreeBSD Port Tools 1.02 (mode: change, diff: SVN)
Comment 1 Mathieu Arnold freebsd_committer 2014-08-14 19:15:08 UTC
When you start it, it says:

[19:59:43] <mat_> Thu Aug 14 19:49:17 2014 : Error: libssl version mismatch.  Built with: 1000108f   Linked: 1000109f
Comment 2 commit-hook freebsd_committer 2014-08-16 20:14:53 UTC
A commit references this bug:

Author: zi
Date: Sat Aug 16 20:14:45 UTC 2014
New revision: 365130
URL: http://svnweb.freebsd.org/changeset/ports/365130

Log:
  - Do not fail to start if there is a mismatch between libssl compile/runtime versions.  We will still print the error, but it will not be fatal.  This is to workaround an issue with pkg where pkg will only reinstall dependant ports if the .so version changes.
  - Bump PORTREVISION

  PR:		192661
  Submitted by:	mat@

Changes:
  head/net/freeradius3/Makefile
  head/net/freeradius3/files/patch-src__main__version.c
Comment 3 Ryan Steinmetz freebsd_committer freebsd_triage 2014-08-16 20:16:46 UTC
I've edited the port such that this is no longer a fatal error until we can fix pkg to deal with this appropriately.  We will still print the message.

The FR guys added this as they've run into numerous segfaults in the past due to version mismatches.
Comment 4 commit-hook freebsd_committer 2014-08-16 20:19:54 UTC
A commit references this bug:

Author: zi
Date: Sat Aug 16 20:19:31 UTC 2014
New revision: 365131
URL: http://svnweb.freebsd.org/changeset/ports/365131

Log:
  - Do not fail to start if there is a mismatch between libssl compile/runtime
  versions.  We will still print the error, but it will not be fatal.  This is to
  workaround an issue with pkg where pkg will only reinstall dependant ports if
  the .so version changes.
  - Bump PORTREVISION

  PR:		192661
  Submitted by:	mat@

Changes:
  head/net/freeradius2/Makefile
  head/net/freeradius2/files/patch-src__main__version.c