Bug 192664 - [stage] mail/cucipop: add stage support
Summary: [stage] mail/cucipop: add stage support
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: John Marino
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-14 19:19 UTC by Vladimir Kondratyev
Modified: 2014-08-15 11:05 UTC (History)
2 users (show)

See Also:


Attachments
cucipop.patch (3.08 KB, patch)
2014-08-14 19:19 UTC, Vladimir Kondratyev
no flags Details | Diff
cucipop.patch (3.31 KB, patch)
2014-08-15 10:29 UTC, Vladimir Kondratyev
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vladimir Kondratyev freebsd_committer 2014-08-14 19:19:29 UTC
Created attachment 145788 [details]
cucipop.patch
Comment 1 John Marino freebsd_committer 2014-08-14 20:32:24 UTC
Thanks!  Do you have any verification available?  In order of preference, examples of what I'm looking for are:

1) "poudriere testport" or "poudriere bulk -t" logs
2) Redports or tinderbox logs
3) "make check-plist" followed by "make stage-qa" output  (https://www.freebsd.org/doc/en/books/porters-handbook/porting-testing.html)

Also, please run "portlint" and paste the output.
Comment 2 Vladimir Kondratyev freebsd_committer 2014-08-15 10:29:26 UTC
Created attachment 145812 [details]
cucipop.patch

Ooops. It tried to install sgid file into stagedir. Sorry
Updated patch attached. This port do not have license at all

[mail] /usr/ports/mail/cucipop% make check-plist
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
===> Checking for directories owned by MTREEs
===> Checking for directories handled by dependencies
===> Checking for items in pkg-plist which are not in STAGEDIR
===> No pkg-plist issues found (check-plist)
[mail] /usr/ports/mail/cucipop% make stage-qa
====> Running Q/A tests (stage-qa)
[mail] /usr/ports/mail/cucipop% portlint
WARN: Makefile: Consider defining LICENSE.
0 fatal errors and 1 warning found.
Comment 3 John Marino freebsd_committer 2014-08-15 10:34:44 UTC
Okay, thanks.  Now you see why I insist on test reports these days. :)

Don't worry about the license, it's not mandatory (nor is the LICENSE framework actively loves so I'm not going to insist on it).

Moving to patch-ready status, thanks for the contribution.
Comment 4 commit-hook freebsd_committer 2014-08-15 11:04:55 UTC
A commit references this bug:

Author: marino
Date: Fri Aug 15 11:04:28 UTC 2014
New revision: 364961
URL: http://svnweb.freebsd.org/changeset/ports/364961

Log:
  Stage mail/cucipop

  PR:		192664
  Submitted by:	Vladimir Kondratiev

Changes:
  head/mail/cucipop/Makefile
  head/mail/cucipop/files/patch-ad
  head/mail/cucipop/pkg-plist
Comment 5 John Marino freebsd_committer 2014-08-15 11:05:30 UTC
thanks!