Bug 192691 - [stage] games/bsdtris: Add stage support.
Summary: [stage] games/bsdtris: Add stage support.
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: John Marino
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-15 20:56 UTC by christian.mangin
Modified: 2014-08-16 19:29 UTC (History)
1 user (show)

See Also:


Attachments
Patch to stagify games/bsdtris (1.89 KB, patch)
2014-08-15 20:56 UTC, christian.mangin
no flags Details | Diff
poudriere testport logs (10.82 KB, text/x-log)
2014-08-15 20:57 UTC, christian.mangin
no flags Details
Adjust the path to /var/games in pathname.h (742 bytes, patch)
2014-08-16 15:00 UTC, christian.mangin
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description christian.mangin 2014-08-15 20:56:39 UTC
Created attachment 145842 [details]
Patch to stagify games/bsdtris

- Add stage support.
Comment 1 christian.mangin 2014-08-15 20:57:00 UTC
Created attachment 145843 [details]
poudriere testport logs
Comment 2 John Marino freebsd_committer 2014-08-15 21:35:51 UTC
Looks good, moving to patch-ready.
Comment 3 John Marino freebsd_committer 2014-08-16 10:38:57 UTC
I'm pretty you don't need this:
@${GZIP_CMD} ${STAGEDIR}${PREFIX}/man/man6/bsdtris.6
Comment 4 John Marino freebsd_committer 2014-08-16 10:40:18 UTC
rather than do this:
@${STRIP_CMD} ${STAGEDIR}${PREFIX}/bin/bsdtris  
we will fix the Makefile that you provide in files.
Comment 5 John Marino freebsd_committer 2014-08-16 10:43:28 UTC
for that matter, why do we need a post-install target when we provide the makefile that includes the install target?  We just fix the install target on the makefile.
Comment 6 John Marino freebsd_committer 2014-08-16 10:52:23 UTC
I think we should move this to /var/games instead of /usr/local/var/games

And the file creation, removal needs to happen in pkg-plist, not vendor makefile.
Comment 7 commit-hook freebsd_committer 2014-08-16 11:24:20 UTC
A commit references this bug:

Author: marino
Date: Sat Aug 16 11:23:29 UTC 2014
New revision: 365072
URL: http://svnweb.freebsd.org/changeset/ports/365072

Log:
  Stage games/bsdtris

  Note that scores file moves from $PREFIX/var/games to /var/games

  PR:		192691
  Submitted by:	Christian Mangin
  Improvements:	marino

Changes:
  head/games/bsdtris/Makefile
  head/games/bsdtris/files/patch-Makefile
  head/games/bsdtris/pkg-plist
Comment 8 John Marino freebsd_committer 2014-08-16 11:25:36 UTC
You might be interested to review my changes to the patch-Makefile.

Thanks for the contribution!
Comment 9 christian.mangin 2014-08-16 15:00:43 UTC
Created attachment 145873 [details]
Adjust the path to /var/games in pathname.h

Thanks for the improvements.

However what good is that game if you can't keep the scores? :)

This new patch:

- Adjust the score file path in pathname.h
- Remove post-patch (no longer needed).

Should I create a new PR ?
Comment 10 John Marino freebsd_committer 2014-08-16 18:19:10 UTC
no, we can handle it here.
Thanks for catching that.
Comment 11 commit-hook freebsd_committer 2014-08-16 19:28:48 UTC
A commit references this bug:

Author: marino
Date: Sat Aug 16 19:27:58 UTC 2014
New revision: 365125
URL: http://svnweb.freebsd.org/changeset/ports/365125

Log:
  games/bsdtris: Fix highscores file location

  I missed one change after relocating the highscores file from
  $PREFIX/var/games to /var/games, so fix that now.

  Noticed by:	Christian Mangin
  PR:		192691

Changes:
  head/games/bsdtris/Makefile
  head/games/bsdtris/files/patch-pathnames.h
Comment 12 John Marino freebsd_committer 2014-08-16 19:29:08 UTC
it's fixed now.