Created attachment 145842 [details] Patch to stagify games/bsdtris - Add stage support.
Created attachment 145843 [details] poudriere testport logs
Looks good, moving to patch-ready.
I'm pretty you don't need this: @${GZIP_CMD} ${STAGEDIR}${PREFIX}/man/man6/bsdtris.6
rather than do this: @${STRIP_CMD} ${STAGEDIR}${PREFIX}/bin/bsdtris we will fix the Makefile that you provide in files.
for that matter, why do we need a post-install target when we provide the makefile that includes the install target? We just fix the install target on the makefile.
I think we should move this to /var/games instead of /usr/local/var/games And the file creation, removal needs to happen in pkg-plist, not vendor makefile.
A commit references this bug: Author: marino Date: Sat Aug 16 11:23:29 UTC 2014 New revision: 365072 URL: http://svnweb.freebsd.org/changeset/ports/365072 Log: Stage games/bsdtris Note that scores file moves from $PREFIX/var/games to /var/games PR: 192691 Submitted by: Christian Mangin Improvements: marino Changes: head/games/bsdtris/Makefile head/games/bsdtris/files/patch-Makefile head/games/bsdtris/pkg-plist
You might be interested to review my changes to the patch-Makefile. Thanks for the contribution!
Created attachment 145873 [details] Adjust the path to /var/games in pathname.h Thanks for the improvements. However what good is that game if you can't keep the scores? :) This new patch: - Adjust the score file path in pathname.h - Remove post-patch (no longer needed). Should I create a new PR ?
no, we can handle it here. Thanks for catching that.
A commit references this bug: Author: marino Date: Sat Aug 16 19:27:58 UTC 2014 New revision: 365125 URL: http://svnweb.freebsd.org/changeset/ports/365125 Log: games/bsdtris: Fix highscores file location I missed one change after relocating the highscores file from $PREFIX/var/games to /var/games, so fix that now. Noticed by: Christian Mangin PR: 192691 Changes: head/games/bsdtris/Makefile head/games/bsdtris/files/patch-pathnames.h
it's fixed now.