Bug 192708 - irc/unreal: QWEBIRC failing connection to UnrealIRCd server.
Summary: irc/unreal: QWEBIRC failing connection to UnrealIRCd server.
Status: Closed Feedback Timeout
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Some People
Assignee: Martin Wilke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-16 16:31 UTC by hdjskfhd
Modified: 2016-01-13 08:01 UTC (History)
4 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description hdjskfhd 2014-08-16 16:31:40 UTC
Error from twistd.log:

2014-08-16 18:16:22+0200 [TimeoutHTTPChannel,2,127.0.0.1] Unhandled Error
	Traceback (most recent call last):
	  File "/usr/local/lib/python2.7/site-packages/twisted/web/http.py", line 1439, in dataReceived
	    finishCallback(data[contentLength:])
	  File "/usr/local/lib/python2.7/site-packages/twisted/web/http.py", line 1668, in _finishRequestBody
	    self.allContentReceived()
	  File "/usr/local/lib/python2.7/site-packages/twisted/web/http.py", line 1731, in allContentReceived
	    req.requestReceived(command, path, version)
	  File "/usr/local/lib/python2.7/site-packages/twisted/web/http.py", line 827, in requestReceived
	    self.process()
	--- <exception caught here> ---
	  File "/usr/local/lib/python2.7/site-packages/twisted/web/server.py", line 189, in process
	    self.render(resrc)
	  File "/usr/local/lib/python2.7/site-packages/twisted/web/server.py", line 238, in render
	    body = resrc.render(self)
	  File "/usr/local/lib/python2.7/site-packages/twisted/web/resource.py", line 250, in render
	    return m(request)
	  File "/usr/local/www/qwebirc/qwebirc/engines/ajaxengine.py", line 32, in decorator
	    x = fn(*args, **kwargs)
	  File "/usr/local/www/qwebirc/qwebirc/engines/ajaxengine.py", line 179, in render_POST
	    return handler(self, request)
	  File "/usr/local/www/qwebirc/qwebirc/engines/ajaxengine.py", line 186, in newConnection
	    _, ip, port = request.transport.getPeer()
	exceptions.TypeError: 'IPv4Address' object is not iterable
	
2014-08-16 18:16:22+0200 [TimeoutHTTPChannel,2,127.0.0.1] "127.0.0.1" - - [16/Aug/2014:16:16:22 +0000] "POST /e/n?r=3a6a3b21450b970d1bf6552c76a7de6b&t=0 HTTP/1.1" 500 95 "http://127.0.0.1:9090/" "Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Firefox/31.0"

How to FIX:

In ajaxengine.py replace line 186 from:
  ticket = login_optional(request)
  _, ip, port = request.transport.getPeer()
to:
ipadd = request.transport.getPeer()
ticket = login_optional(request)
_, ip, port = ipadd.type, ipadd.host, ipadd.port

Like here: http://hg.qwebirc.org/qwebirc/issue/335/exceptionstypeerror-ipv4address-object-is

Thanks.
Comment 1 John Marino freebsd_committer freebsd_triage 2014-08-16 19:51:28 UTC
which port does this pertain too?  It helps to put <category>/<portname> in the title.
Comment 2 John Marino freebsd_committer freebsd_triage 2014-08-18 21:08:35 UTC
sorry Mat, the submitter wouldn't tell me the name of the port.  I finally looked it up but I was tempted to close the PR. :)
Comment 3 Mathieu Arnold freebsd_committer freebsd_triage 2014-08-27 10:45:45 UTC
Mmmm, is this a problem related to unreal, or is it a twisted (?) or qwebirc (?) problem ? (cc'ing qwebirc's and twister's maintainers)