Bug 192731 - [patch] [build] typo in lib/libatf/libatf-c++/Makefile; LIBATFC should be LIBATF_C
Summary: [patch] [build] typo in lib/libatf/libatf-c++/Makefile; LIBATFC should be LIB...
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: conf (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Some People
Assignee: Enji Cooper
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-17 05:45 UTC by Enji Cooper
Modified: 2014-08-21 17:37 UTC (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Enji Cooper freebsd_committer freebsd_triage 2014-08-17 05:45:12 UTC 
Before the fix:

# (cd lib/atf/libatf-c++/; set -x; make -VDPADD; make -VLDADD)
+ make -VDPADD

+ make -VLDADD
-latf-c

After the fix:

# git diff lib/atf/libatf-c++/Makefile
diff --git a/lib/atf/libatf-c++/Makefile b/lib/atf/libatf-c++/Makefile
index 163f7fb..a7a8d91 100644
--- a/lib/atf/libatf-c++/Makefile
+++ b/lib/atf/libatf-c++/Makefile
@@ -33,7 +33,7 @@ PRIVATELIB=   true
 SHLIB_MAJOR=   1
 
 # libatf-c++ depends on the C version of the ATF library to build.
-DPADD=         ${LIBATFC}
+DPADD=         ${LIBATF_C}
 LDADD=         -latf-c
 
 LDFLAGS+=      -L${.OBJDIR}/../libatf-c
# (cd lib/atf/libatf-c++/; set -x; make -VDPADD; make -VLDADD)
+ make -VDPADD
/usr/obj/usr/src/lib/atf/libatf-c/libatf-c.a
+ make -VLDADD
-latf-c
Comment 1 commit-hook freebsd_committer freebsd_triage 2014-08-17 23:31:30 UTC 
A commit references this bug:

Author: ngie
Date: Sun Aug 17 23:30:45 UTC 2014
New revision: 270116
URL: http://svnweb.freebsd.org/changeset/base/270116

Log:
  Fix typo in lib/atf/libatfc++/Makefile

  LIBATFC should be LIBATF_C; this was missed in the initial import
  (r241823)

  PR: 192731
  MFC after: 3 days
  Phabric: D619
  Approved by: rpaulo (mentor)

Changes:
  head/lib/atf/libatf-c++/Makefile
Comment 2 commit-hook freebsd_committer freebsd_triage 2014-08-21 17:37:19 UTC 
A commit references this bug:

Author: ngie
Date: Thu Aug 21 17:36:42 UTC 2014
New revision: 270286
URL: http://svnweb.freebsd.org/changeset/base/270286

Log:
  MFC r270116:

   Fix typo in lib/atf/libatfc++/Makefile

   LIBATFC should be LIBATF_C; this was missed in the initial import
   (r241823)

   PR: 192731
   MFC after: 3 days
   Phabric: D619
   Approved by: rpaulo (mentor)

Changes:
_U  stable/10/
  stable/10/lib/atf/libatf-c++/Makefile