Bug 192740 - [patch] mail/milter-greylist - fix some Makefile issues
Summary: [patch] mail/milter-greylist - fix some Makefile issues
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: John Marino
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-17 13:08 UTC by Daniel Austin
Modified: 2014-08-17 13:38 UTC (History)
1 user (show)

See Also:

Attachments
update/simplify Makefile and plist (5.07 KB, patch)
2014-08-17 13:08 UTC, Daniel Austin 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Austin 2014-08-17 13:08:12 UTC 
Created attachment 145917 [details]
update/simplify Makefile and plist

- update and simplify Makefile
- ensure manpages are always installed
- remove an absolute assignment from BUILD_DEPENDS into RUN_DEPENDS
- move PORTDOCS and PORTEXAMPLES install into do-install from post-install
- update an include from absolute to relative path

poudriere testport logs at:

http://poudriere.dan.tm/latest-per-pkg/milter-greylist/4.4.3_3/
Comment 1 John Marino freebsd_committer freebsd_triage 2014-08-17 13:15:25 UTC 
I'll take this.
Comment 2 commit-hook freebsd_committer freebsd_triage 2014-08-17 13:37:49 UTC 
A commit references this bug:

Author: marino
Date: Sun Aug 17 13:37:47 UTC 2014
New revision: 365186
URL: http://svnweb.freebsd.org/changeset/ports/365186

Log:
  mail/milter-greylist: Fix and simplify makefile

  This port was conditionally installing manpages per option, which is
  not allowed.  While fixing this, align it with the recently modernized
  milter-greylist-devel port, which includes:

   * Remove assignment of BUILD_DEPENDS to RUN_DEPENDS (illegal).  The
     BUILD_DEPENDS is empty by default
   * Use options to set dependencies and configure arguments
   * Use PORTDOCS and PORTEXAMPLES
   * Wrap to 80 columns
   * Combine post-install target with do-install target
   * include local .mk with relative path instead of hardcoded PORTSDIR

  PR:		192740
  Submitted by:	Daniel Austin (per my request)
  Approved by:	Just Fix It

Changes:
  head/mail/milter-greylist/Makefile
  head/mail/milter-greylist/pkg-plist
Comment 3 John Marino freebsd_committer freebsd_triage 2014-08-17 13:38:46 UTC 
Thanks for doing that, Daniel!