Bug 192833 - [maintainer-update] databases/cppdb
[maintainer-update] databases/cppdb
Status: Closed FIXED
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s)
Latest
Any Any
: --- Affects Many People
Assigned To: William Grzybowski
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-08-19 14:52 UTC by Mohammad S. Babaei
Modified: 2014-08-20 16:17 UTC (History)
1 user (show)

See Also:


Attachments
shar file including the patch (6.34 KB, text/plain)
2014-08-19 14:52 UTC, Mohammad S. Babaei
no flags Details
The patch file (386 bytes, patch)
2014-08-19 15:04 UTC, Mohammad S. Babaei
no flags Details | Diff
cppdb-0.3.1,2.diff against the port (1.01 KB, patch)
2014-08-19 19:40 UTC, Mohammad S. Babaei
no flags Details | Diff
cppdb-0.3.1,2.diff (1.01 KB, patch)
2014-08-19 19:43 UTC, Mohammad S. Babaei
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mohammad S. Babaei 2014-08-19 14:52:51 UTC
Created attachment 146033 [details]
shar file including the patch

Fixed the CMake script which was not able to find MySQL / MariaDB client library on FreeBSD.
Comment 1 John Marino freebsd_committer 2014-08-19 14:57:41 UTC
shar files are *only* for new ports.

Please provide a diff of the changes needed for your port (one text file), thanks.
Comment 2 Mohammad S. Babaei 2014-08-19 15:04:19 UTC
Created attachment 146035 [details]
The patch file

Sorry, I didn't knew that.

Enclosed please find the patch file.
Comment 3 John Marino freebsd_committer 2014-08-19 15:11:28 UTC
no, that's not quite right either.

You provided a patch against the software.

I asked for a patch against the port.
That means if you want to add a patch to the port, you need to provide a patch that adds the patch.

There are many open PRs where you can look at the attachments for examples.

And if cppdb currently builds, you'll want to patch the Makefile to increase PORTREVISION number too.
Comment 4 Mohammad S. Babaei 2014-08-19 19:40:18 UTC
Created attachment 146045 [details]
cppdb-0.3.1,2.diff against the port

Thanks about the info and pardon me because generally I'm a forgetful person (For my previous update I made a diff file, but I forgot the process).

And about the revision, actually this should be revision 2, since as I said in the past I made another update due to the changes in the Makefile not the software itself.

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=188204#attach_141413
Comment 5 Mohammad S. Babaei 2014-08-19 19:43:02 UTC
Created attachment 146046 [details]
cppdb-0.3.1,2.diff

Ops, another small mistake.
Comment 6 John Marino freebsd_committer 2014-08-19 22:54:42 UTC
See, that wasn't so hard. :)
Comment 7 Mohammad S. Babaei 2014-08-20 05:29:48 UTC
ye(In reply to John Marino from comment #6)
> See, that wasn't so hard. :)

Yep, anyway thanks for the info :)
Comment 8 commit-hook freebsd_committer 2014-08-20 16:17:46 UTC
A commit references this bug:

Author: wg
Date: Wed Aug 20 16:17:31 UTC 2014
New revision: 365476
URL: http://svnweb.freebsd.org/changeset/ports/365476

Log:
  databases/cppdb: fix mysql/mariadb support

  PR:		192833
  Submitted by:	maintainer

Changes:
  head/databases/cppdb/Makefile
  head/databases/cppdb/files/
  head/databases/cppdb/files/patch-CMakeLists.txt