Bug 192932 - [stage] lang/tuareg-mode.el: update to 2.0.8
Summary: [stage] lang/tuareg-mode.el: update to 2.0.8
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-22 21:20 UTC by Michael Grünewald
Modified: 2014-08-24 17:13 UTC (History)
2 users (show)

See Also:

Attachments
Update for tuareg-mode.el 2.0.8 (3.02 KB, patch)
2014-08-22 21:20 UTC, Michael Grünewald 		no flags Details | Diff
Update for tuareg-mode.el 2.0.8 (2.68 KB, patch)
2014-08-22 21:23 UTC, Michael Grünewald 		michipili: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Grünewald 2014-08-22 21:20:39 UTC 
Created attachment 146166 [details]
Update for tuareg-mode.el 2.0.8

This is an update for lang/tuareg-mode.el to version 2.0.8.

It also:
* adopts the port
* adds staging
* adds a pkg-plist
* supports OPTIONS_DEFINE
* uses Github
* removes obsolete comments from the Makefile.
Comment 1 Michael Grünewald 2014-08-22 21:23:37 UTC 
Created attachment 146167 [details]
Update for tuareg-mode.el 2.0.8

Submit a patch *without* svn diff trailing garbage due to new file pkg-plist.
Comment 2 John Marino freebsd_committer freebsd_triage 2014-08-23 11:28:39 UTC 
This is a staging PR, normally I ask for logs for these (they very often fail to build in poudriere testport).

But I think you said you are on vacation or away or something, so I will cross my fingers and move to patch-ready (and advise commiters to take at their own risk)
Comment 3 Adam Weinberger freebsd_committer freebsd_triage 2014-08-23 17:27:16 UTC 
You've removed ELISP_FILES= and it no longer packages.

===========================================================================
====> Running Q/A tests (stage-qa)
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
===> Checking for directories owned by MTREEs
===> Checking for directories handled by dependencies
===> Checking for items in pkg-plist which are not in STAGEDIR
Error: Missing: %%DOCSDIR%%/README.md
Error: Missing: %%EMACS_SITE_LISPDIR%%/ocamldebug.el
Error: Missing: %%EMACS_SITE_LISPDIR%%/ocamldebug.elc
Error: Missing: %%EMACS_SITE_LISPDIR%%/tuareg.el
Error: Missing: %%EMACS_SITE_LISPDIR%%/tuareg.elc
Error: Missing: @dirrmtry %%DOCSDIR%%
===> Error: Plist issues found.
*** Error code 1

Stop.
make: stopped in /usr/ports/lang/tuareg-mode.el
Comment 4 John Marino freebsd_committer freebsd_triage 2014-08-24 16:56:42 UTC 
adam, if you know how to fix this, I'd just do it.  I think Michael is away for a bit.
Comment 5 commit-hook freebsd_committer freebsd_triage 2014-08-24 17:13:14 UTC 
A commit references this bug:

Author: adamw
Date: Sun Aug 24 17:13:00 UTC 2014
New revision: 365974
URL: http://svnweb.freebsd.org/changeset/ports/365974

Log:
  Update to version 2.0.8.

  Also:
  * pass maintainership to submitter
  * stage
  * add DOCS option
  * use Github
  * remove obsolete comments from the Makefile.

  PR:		192932
  Submitted by:	Michael Gr??newald

Changes:
  head/lang/tuareg-mode.el/Makefile
  head/lang/tuareg-mode.el/distinfo
Comment 6 Adam Weinberger freebsd_committer freebsd_triage 2014-08-24 17:13:55 UTC 
Committed with modifications.