Bug 192941 - [patch] multimedia/mpv build fails with pulseaudio option enabled
Summary: [patch] multimedia/mpv build fails with pulseaudio option enabled
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Grzegorz Blach
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-23 12:06 UTC by rsmith
Modified: 2014-09-07 18:37 UTC (History)
0 users

See Also:


Attachments
Patch for multimedia/mpv (624 bytes, patch)
2014-08-23 12:06 UTC, rsmith
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description rsmith 2014-08-23 12:06:00 UTC
Created attachment 146174 [details]
Patch for multimedia/mpv

Trying to build mpv with the pulseaudio option enabled fails;

    Checking for PulseAudio audio output                                    : no 
    You manually enabled the feature 'pulse', but the autodetection check failed.
    *** Error code 1

    Stop.
    make[1]: stopped in /usr/ports/multimedia/mpv
    *** Error code 1

The pulseaudio port *is* installed;

    # pkg info -x pulseaudio
    pulseaudio-0.9.23_2

The test fails because it tests for libpulse >= 1.0 while the version in ports is 0.9.23.

So I patched (see attachment) the mpv port to accept libpulse >= 0.9, built and tested mpv without problems on 10-STABLE amd64.

The patched port was tested with: 

    env DEVELOPER=yes make stage && make check-plist && make package

The build succeeded. The output of the above command (grepped for '^===') is shown below;

    ===>  License GPLv2 accepted by the user
    ===>  Found saved configuration for mpv-0.5.0_1,1
    ===>   mpv-0.5.0_1,1 depends on file: /usr/local/sbin/pkg - found
    ===> Fetching all distfiles required by mpv-0.5.0_1,1 for building
    ===>  Extracting for mpv-0.5.0_1,1
    ===>  Patching for mpv-0.5.0_1,1
    ===>  Applying FreeBSD patches for mpv-0.5.0_1,1
    ===>   mpv-0.5.0_1,1 depends on executable: rst2man - found
    ===>   mpv-0.5.0_1,1 depends on executable: update-desktop-database - found
    ===>   mpv-0.5.0_1,1 depends on executable: pkgconf - found
    ===>   mpv-0.5.0_1,1 depends on file: /usr/local/bin/python2.7 - found
    ===>   mpv-0.5.0_1,1 depends on file: /usr/local/libdata/pkgconfig/x11.pc - found
    ===>   mpv-0.5.0_1,1 depends on file: /usr/local/libdata/pkgconfig/xv.pc - found
    ===>   mpv-0.5.0_1,1 depends on file: /usr/local/libdata/pkgconfig/xxf86vm.pc - found
    ===>   mpv-0.5.0_1,1 depends on executable: gtk-update-icon-cache - found
    ===>   mpv-0.5.0_1,1 depends on shared library: libavcodec.so - found (/usr/local/lib/libavcodec.so.55.52.102)
    ===>   mpv-0.5.0_1,1 depends on shared library: libass.so - found (/usr/local/lib/libass.so.5.0.0)
    ===>   mpv-0.5.0_1,1 depends on shared library: libdvdread.so - found (/usr/local/lib/libdvdread.so.5)
    ===>   mpv-0.5.0_1,1 depends on shared library: libdvdnav.so - found (/usr/local/lib/libdvdnav.so.4.2.1)
    ===>   mpv-0.5.0_1,1 depends on shared library: liblcms2.so - found (/usr/local/lib/liblcms2.so.2.0.6)
    ===>   mpv-0.5.0_1,1 depends on shared library: libpulse.so - found (/usr/local/lib/libpulse.so.0)
    ===>   mpv-0.5.0_1,1 depends on shared library: liblua-5.2.so - found (/usr/local/lib/liblua-5.2.so)
    ===>   mpv-0.5.0_1,1 depends on shared library: libatk-1.0.so - found (/usr/local/lib/libatk-1.0.so.0)
    ===>   mpv-0.5.0_1,1 depends on shared library: libgdk_pixbuf-2.0.so - found (/usr/local/lib/libgdk_pixbuf-2.0.so.0.2800.2)
    ===>   mpv-0.5.0_1,1 depends on shared library: libglib-2.0.so - found (/usr/local/lib/libglib-2.0.so.0)
    ===>   mpv-0.5.0_1,1 depends on shared library: libpcre.so - found (/usr/local/lib/libpcre.so.3)
    ===>   mpv-0.5.0_1,1 depends on shared library: libpango-1.0.so - found (/usr/local/lib/libpango-1.0.so.0.3400.1)
    ===>  Configuring for mpv-0.5.0_1,1
    ===>  Building for mpv-0.5.0_1,1
    ===>  Staging for mpv-0.5.0_1,1
    ===>   mpv-0.5.0_1,1 depends on executable: update-desktop-database - found
    ===>   mpv-0.5.0_1,1 depends on file: /usr/local/libdata/pkgconfig/x11.pc - found
    ===>   mpv-0.5.0_1,1 depends on file: /usr/local/libdata/pkgconfig/xv.pc - found
    ===>   mpv-0.5.0_1,1 depends on file: /usr/local/libdata/pkgconfig/xxf86vm.pc - found
    ===>   mpv-0.5.0_1,1 depends on executable: gtk-update-icon-cache - found
    ===>   Generating temporary packing list
    ====> Compressing man pages (compress-man)
    ====> Running Q/A tests (stage-qa)
    ====> Checking for pkg-plist issues (check-plist)
    ===> Parsing plist
    ===> Checking for items in STAGEDIR missing from pkg-plist
    ===> Checking for directories owned by MTREEs
    ===> Checking for directories handled by dependencies
    ===> Checking for items in pkg-plist which are not in STAGEDIR
    ===> No pkg-plist issues found (check-plist)
    ===>  Building package for mpv-0.5.0_1,1
Comment 1 John Marino freebsd_committer 2014-08-23 13:23:51 UTC
over to maintainer
Comment 2 commit-hook freebsd_committer 2014-09-07 18:36:18 UTC
A commit references this bug:

Author: gblach
Date: Sun Sep  7 18:35:33 UTC 2014
New revision: 367596
URL: http://svnweb.freebsd.org/changeset/ports/367596

Log:
  - Fix build when PULSEAUDIO option is enabled
  - Bump PORTREVISION

  PR:		192941
  Submitted by:	rsmith <at> xs4all <dot> nl

Changes:
  head/multimedia/mpv/Makefile
Comment 3 Grzegorz Blach freebsd_committer 2014-09-07 18:36:57 UTC
Committed with minor changes, thanks.