Bug 193059 - [maintainer update] sysutils/backuppc: revert some changes in pkg-plist
[maintainer update] sysutils/backuppc: revert some changes in pkg-plist
Status: Closed FIXED
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s)
Latest
Any Any
: --- Affects Some People
Assigned To: William Grzybowski
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-08-27 07:19 UTC by Alexander Moisseev
Modified: 2014-08-30 16:47 UTC (History)
2 users (show)

See Also:


Attachments
patch: revert changes in pkg-plist (1.61 KB, patch)
2014-08-27 07:19 UTC, Alexander Moisseev
no flags Details | Diff
patch: revert changes in pkg-plist, remove config files from STAGEDIR (2.09 KB, patch)
2014-08-29 06:31 UTC, Alexander Moisseev
moiseev: maintainer‑approval+
Details | Diff
patch: Move CGI documentation to WWWDIR (2.65 KB, patch)
2014-08-30 12:01 UTC, Alexander Moisseev
moiseev: maintainer‑approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Moisseev 2014-08-27 07:19:50 UTC
Created attachment 146359 [details]
patch: revert changes in pkg-plist

- Revert changes in pkg-plist made by commiter.
- Bump portrevision.

1. Main html doc should be unconditionally installed since CGI uses the BackupPC.html as a documentation page.

2. .sample files actually are templates for the configuration script and should not be installed as working configuration files.
Comment 1 Alexander Moisseev 2014-08-27 07:27:40 UTC
https://redports.org/buildarchive/20140827071041-30592/
Comment 2 John Marino freebsd_committer 2014-08-27 08:55:47 UTC
wg@ is CC'd already, but assigning him the PR since it appears the maintainer is questioning one of his commits.
Comment 3 William Grzybowski freebsd_committer 2014-08-27 11:53:22 UTC
Redports/tinderbox sucks.



====> Running Q/A tests (stage-qa)
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: %%ETCDIR%%/config.pl
Error: Orphaned: %%ETCDIR%%/hosts
===> Checking for directories owned by MTREEs
===> Checking for directories handled by dependencies
===> Checking for items in pkg-plist which are not in STAGEDIR
===> Error: Plist issues found.
*** Error code 1

Stop.
make: stopped in /usr/ports/sysutils/backuppc
====>> Error: check-plist failures detected
build of /usr/ports/sysutils/backuppc ended at Wed Aug 27 08:52:11 BRT 2014
build time: 00:00:14
====>> Error: Build failed in phase: check-plist
====>> Cleaning up
====>> Umounting file systems
Comment 4 Alexander Moisseev 2014-08-29 06:31:51 UTC
Created attachment 146479 [details]
patch: revert changes in pkg-plist, remove config files from STAGEDIR

I removed unneeded configuration files from STAGEDIR to avoid the thinderbox error.

https://redports.org/buildarchive/20140829060933-09926/
Comment 5 commit-hook freebsd_committer 2014-08-29 12:27:43 UTC
A commit references this bug:

Author: wg
Date: Fri Aug 29 12:26:43 UTC 2014
New revision: 366504
URL: http://svnweb.freebsd.org/changeset/ports/366504

Log:
  sysutils/backuppc: revert a couple of changes

  - Main doc html is used by the application
  - sample files are actually templates for the configuration script

  PR:		193059
  Submitted by:	maintainer

Changes:
  head/sysutils/backuppc/Makefile
  head/sysutils/backuppc/pkg-plist
Comment 6 Alexander Moisseev 2014-08-29 13:05:05 UTC
Hi William,

What reason do you have to delete "@dirrm %%DOCSDIR%%" from pkg-plist?
Now the port leaves DOCSDIR on uninstall if it was built with WITHOUT="DOCS".
Comment 7 William Grzybowski freebsd_committer 2014-08-29 13:09:58 UTC
Because poudriere complains about duplicate docs entry if you don't.

Relying on a file installed into portdocs is completely wrong.
You should patch the software to install the file to /usr/local/share/${PORTNAME}
Comment 8 Alexander Moisseev 2014-08-30 12:01:20 UTC
Created attachment 146529 [details]
patch: Move CGI documentation to WWWDIR

- Add separate copy of main documentation to WWWDIR
- Bump portrevision

https://redports.org/buildarchive/20140830115010-47871/
Comment 9 commit-hook freebsd_committer 2014-08-30 16:47:10 UTC
A commit references this bug:

Author: wg
Date: Sat Aug 30 16:46:18 UTC 2014
New revision: 366645
URL: http://svnweb.freebsd.org/changeset/ports/366645

Log:
  sysutils/backuppc: copy required html file to WWWDIR

  PR:		193059
  Submitted by:	maintainer

Changes:
  head/sysutils/backuppc/Makefile
  head/sysutils/backuppc/files/patch-lib__BackupPC__CGI__View.pm
  head/sysutils/backuppc/pkg-plist