Bug 193063 - [PATCH] security/vlock: fix permissions handling
Summary: [PATCH] security/vlock: fix permissions handling
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Ganael LAPLANCHE
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-27 12:01 UTC by Dmitry Marakasov
Modified: 2014-09-04 08:25 UTC (History)
2 users (show)

See Also:

Attachments
vlock-2.2.3.patch (1.00 KB, patch)
2014-08-27 12:01 UTC, Dmitry Marakasov 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Marakasov 2014-08-27 12:01:08 UTC 
Created attachment 146368 [details]
vlock-2.2.3.patch

Use @mode/@group to reset permissions to default

This is more correct than passing SHAREMODE/SHAREGRP via PLIST_SUB, and also fixes the following problem: non-default permissions are in effect past the end of plist, where license stuff is added, so check-sanity complains:

====>> Checking for extra files and directories
====>> Files or directories modified:
share/licenses permissions (0755, 0444)
build of /usr/ports/security/vlock ended at Wed Aug 27 15:53:30 MSK 2014
====>> Error: Build failed in phase: leftovers

Port maintainer (martymac@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 1.02 (mode: change, diff: SVN)
Comment 1 commit-hook freebsd_committer 2014-09-04 07:49:32 UTC 
A commit references this bug:

Author: martymac
Date: Thu Sep  4 07:49:02 UTC 2014
New revision: 367242
URL: http://svnweb.freebsd.org/changeset/ports/367242

Log:
  Fix permissions (@group/@mode) handling

  PR:		193063
  Submitted by:	amdmi3

Changes:
  head/security/vlock/Makefile
  head/security/vlock/pkg-plist
Comment 2 Ganael LAPLANCHE freebsd_committer 2014-09-04 08:25:49 UTC 
Committed, thanks!