Bug 193069 - Update math/superlu: add staging support.
Summary: Update math/superlu: add staging support.
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Thierry Thomas
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-08-27 16:21 UTC by Pedro F. Giffuni
Modified: 2014-08-28 19:18 UTC (History)
1 user (show)

See Also:

Attachments
Port update diff (4.21 KB, patch)
2014-08-27 16:21 UTC, Pedro F. Giffuni 		no flags Details | Diff
superlu_4.3.diff (12.15 KB, patch)
2014-08-27 17:50 UTC, Thierry Thomas 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pedro F. Giffuni freebsd_committer freebsd_triage 2014-08-27 16:21:55 UTC 
Created attachment 146381 [details]
Port update diff

The superlu algorithm is very different to superlu_mt so it would not be good to drop this port due to lack of staging.

This port also needs updating but for now the staging support is essential.

While here:
Fix portlint issues
Drop a document that is not available in the main website anymore.
Replace gotoblas2 with openblas.
Comment 1 Thierry Thomas freebsd_committer freebsd_triage 2014-08-27 17:48:15 UTC 
Hello Pedro,

I was just trying to upgrade this port to the latest (4.3).
The attached patch does the trick, and it passes the regression-tests successfully.

Could you please check it?

Note: MAKE_JOBS_UNSAFE is set, but I guess that it would be easy to remove it. 

Best regards,
Comment 2 Thierry Thomas freebsd_committer freebsd_triage 2014-08-27 17:50:08 UTC 
Created attachment 146384 [details]
superlu_4.3.diff
Comment 3 Pedro F. Giffuni freebsd_committer freebsd_triage 2014-08-27 18:22:11 UTC 
Thank you Thierry!

One minor issue:
_______
===>  Extracting for superlu-4.3.20060201
=> SHA256 Checksum OK for superlu/superlu_4.3.tar.gz.
===>  Missing license file for BSD3CLAUSE in README
*** Error code 1

Stop.
______

Drop LICENSE_FILE and it works.

Also: why we need DISTVERSION? SuperLu 4.3 was last updated 12/14/2011 (20111214)
Comment 4 Thierry Thomas freebsd_committer freebsd_triage 2014-08-27 20:35:46 UTC 
Thanks! I'm not avilable right now, but I'll commit it ASAP.
Comment 5 commit-hook freebsd_committer freebsd_triage 2014-08-28 19:16:53 UTC 
A commit references this bug:

Author: thierry
Date: Thu Aug 28 19:16:46 UTC 2014
New revision: 366447
URL: http://svnweb.freebsd.org/changeset/ports/366447

Log:
  - Stagify

  - Upgrade to 4.3

  Changelog at <http://crd-legacy.lbl.gov/~xiaoye/SuperLU/changes.html>.

  PR:		ports/193069
  Submitted by:	pfg

Changes:
  head/math/superlu/Makefile
  head/math/superlu/distinfo
  head/math/superlu/files/patch-SRC-Makefile
  head/math/superlu/files/patch-TESTING_Makefile
  head/math/superlu/files/patch-make.inc
  head/math/superlu/pkg-plist
Comment 6 Thierry Thomas freebsd_committer freebsd_triage 2014-08-28 19:18:06 UTC 
Committed, thanks!