Bug 193096 - [PATCH] security/py-oauthlib: update to 0.6.3
Summary: [PATCH] security/py-oauthlib: update to 0.6.3
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kubilay Kocak
URL:
Keywords:
Depends on: 193095
Blocks: 193097
  Show dependency tree / graph
 
Reported: 2014-08-28 14:50 UTC by Muhammad Moinur Rahman
Modified: 2014-12-22 05:24 UTC (History)
1 user (show)

See Also:

Attachments
patch for py-oauthlib-0.6.3 (1.78 KB, patch)
2014-08-28 14:50 UTC, Muhammad Moinur Rahman 		no flags Details | Diff
patch for py-oauthlib-0.6.3 (1.78 KB, patch)
2014-09-17 07:56 UTC, Muhammad Moinur Rahman 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Muhammad Moinur Rahman freebsd_committer freebsd_triage 2014-08-28 14:50:54 UTC 
Created attachment 146454 [details]
patch for py-oauthlib-0.6.3

- Update to 0.6.3
- USE_PYTHON
- Change MASTER_SITES to CHEESESHOP

Poudriere logs:
http://pdr.s.ubze.ro/bulk/latest-per-pkg/py27-oauthlib/0.6.3/
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2014-08-30 03:19:48 UTC 
Review:

- Add LICENSE_FILE
- Lowercase PyJWT in TEST_DEPENDS, SIGNEDTOKEN_RUN_DEPENDS (bug 193095)
- Include summary rationale (reasons) for non-trivial changes (MASTER_SITES)

Q: Do test still run after switching from GITHUB -> CHEESESHOP?

Some upstreams dont correctly include tests, test data, etc in their sdist's, so I use github until they do (after creating an issue/patch to address the missing files)

Pending updated patch
Comment 2 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2014-09-17 07:56:27 UTC 
Created attachment 147392 [details]
patch for py-oauthlib-0.6.3
Comment 3 Muhammad Moinur Rahman freebsd_committer freebsd_triage 2014-09-17 08:02:35 UTC 
1. Why should we have to add LICENSE_FILE? BSD3CLAUSE is in framework.
2. Lowercased in updated patch
3. Easier to check for version updates through portscout.

Tests run fine. 

(In reply to Kubilay Kocak from comment #1)
> Review:
> 
> - Add LICENSE_FILE
> - Lowercase PyJWT in TEST_DEPENDS, SIGNEDTOKEN_RUN_DEPENDS (bug 193095)
> - Include summary rationale (reasons) for non-trivial changes (MASTER_SITES)
> 
> Q: Do test still run after switching from GITHUB -> CHEESESHOP?
> 
> Some upstreams dont correctly include tests, test data, etc in their
> sdist's, so I use github until they do (after creating an issue/patch to
> address the missing files)
> 
> Pending updated patch
Comment 4 commit-hook freebsd_committer freebsd_triage 2014-12-22 05:08:01 UTC 
A commit references this bug:

Author: koobs
Date: Mon Dec 22 05:07:44 UTC 2014
New revision: 375208
URL: https://svnweb.freebsd.org/changeset/ports/375208

Log:
  security/py-oauthlib: Update to 0.7.2, Add OPTIONS

  - Update to 0.7.2
  - Switch distfiles from GitHub -> PyPi (CHEESESHOP)
  - Add RSA, SIGNALS and SIGNEDTOKEN (JWT) and TESTS options
  - Adjust RUN_DEPENDS and TEST_DEPENDS
  - Remove uncessary setup.py patch

  Changes:

    * https://github.com/idan/oauthlib/blob/0.7.2/CHANGELOG.rst

  PR:		193096
  Submitted by:	Muhammad Moinur Rahman <5u623l20 at gmail com> (with changes)

Changes:
  head/security/py-oauthlib/Makefile
  head/security/py-oauthlib/distinfo
  head/security/py-oauthlib/files/
Comment 5 Kubilay Kocak freebsd_committer freebsd_triage 2014-12-22 05:24:22 UTC 
Committed with changes. Thanks Muhammad!