Bug 193215 - [stage] net/balance request maintainership
Summary: [stage] net/balance request maintainership
Status: Closed Not Accepted
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-01 05:32 UTC by Chris Hutchinson
Modified: 2014-09-05 02:23 UTC (History)
2 users (show)

See Also:


Attachments
net/balance [maintainer] STAGE pkg-plist (1.05 KB, patch)
2014-09-01 05:32 UTC, Chris Hutchinson
no flags Details | Diff
net/balance [request for maintainer] STAGE LICENSE COMMENT pkg-plist svn diff (test log) (1.36 KB, patch)
2014-09-03 22:47 UTC, Chris Hutchinson
no flags Details | Diff
net/balance [request for maintainer] output log for 2014-09-03.diff (net-balance-tests-out) (2.80 KB, text/plain)
2014-09-03 22:49 UTC, Chris Hutchinson
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Hutchinson 2014-09-01 05:32:06 UTC
Created attachment 146625 [details]
net/balance [maintainer] STAGE pkg-plist

net/balance

adds MAINTAINER, additional entry to pkg-plist

Trivial update. All total; 3 lines.

Please see svn(1) diff(1), for details.

--Chris

P.S. This is the last [new] one I'll submit, until
I get poudriere working properly.
Sorry for any [previous] difficulties, and thanks
for all your help, and understanding.
Comment 1 John Marino freebsd_committer freebsd_triage 2014-09-01 10:53:11 UTC
<grumble>
seriously, please stop putting "[maintainer]" in the title when you aren't already the maintainer.  This is the second time I've asked.
Comment 2 John Marino freebsd_committer freebsd_triage 2014-09-01 10:58:04 UTC
And rejected, it contains "MAN1="

I have to believe you don't understand why "MAN<X>=" in staging PR is wrong.  I've pointed this out about 5 times and you keep doing it.  The only reasonable explanation is you don't know how to handle staging.

you aren't following this:
https://wiki.freebsd.org/ports/StageDir

I'm rejecting this PR because it's again untested and this is grossly wrong.
It didn't even contain the minimum of "make check-plist", "make stage-qa", portlint, and "make check-sanity" which I have requested numerous times.


These are REQUIREMENTS for your that I won't waive.
Comment 3 Chris Hutchinson 2014-09-01 20:32:24 UTC
(In reply to John Marino from comment #1)
> <grumble>
> seriously, please stop putting "[maintainer]" in the title when you aren't
> already the maintainer.  This is the second time I've asked.

Sorry. This is what I have always used in the past, given it is
maintainer related (request for maintainer).
I thought it pertinent. Would you prefer [maintainer request]?
or ???

--Chris
Comment 4 John Marino freebsd_committer freebsd_triage 2014-09-01 20:38:04 UTC
No.  I prefer "and request maintainership" in the title.

I've changed your titles quite a few times and those changes serve as examples.  I assume you got notices showing the title change.  So ideally you would notice these changes which show 1) what not to do and 2) what to do instead.

but in this case I explicitly pointed it out.



"[maintainer]" means the current maintainer opened the PR, not somebody that wants to be a maintainer.  It's a way of establishing credibility quickly.
Comment 5 Chris Hutchinson 2014-09-01 21:13:59 UTC
(In reply to John Marino from comment #4)
> No.  I prefer "and request maintainership" in the title.
> 
> I've changed your titles quite a few times and those changes serve as
> examples.  I assume you got notices showing the title change.  So ideally
> you would notice these changes which show 1) what not to do and 2) what to
> do instead.
> 
> but in this case I explicitly pointed it out.
> 
> 
> 
> "[maintainer]" means the current maintainer opened the PR, not somebody that
> wants to be a maintainer.  It's a way of establishing credibility quickly.

Sorry. I _apparently_ overlooked (missed) the title change.
Point _well_ taken, and acknowledged. :)

--Chris
Comment 6 Chris Hutchinson 2014-09-03 22:47:14 UTC
Created attachment 146755 [details]
net/balance [request for maintainer] STAGE LICENSE COMMENT pkg-plist svn diff (test log)

net/balance

request for maintainer

adds STAGEDIR MAINTAINER
changes Makefile pkg-plist

This is a request for MAINTAINERship.
I have added STAGEDIR to this, and have made additional modifications
to ensure that this port meets current requirements. Please see
2014-09-03.diff, and net-balance-tests-out, for details.

Thank you for all your time, and consideration.

--Chris
Comment 7 Chris Hutchinson 2014-09-03 22:49:51 UTC
Created attachment 146756 [details]
net/balance [request for maintainer] output log for 2014-09-03.diff (net-balance-tests-out)

net/balance

Requisite testing logs for 2014-09-03.diff, also attached.

Thank you for all your time, and consideration.

--Chris
Comment 8 Chris Hutchinson 2014-09-05 02:23:32 UTC
Needs Triage