Bug 193287 - emulators/pipelight: ignore bash from PATH
Summary: emulators/pipelight: ignore bash from PATH
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kris Moore
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-03 16:02 UTC by Jan Beich
Modified: 2014-09-05 18:57 UTC (History)
0 users

See Also:


Attachments
shebangfix (689 bytes, patch)
2014-09-03 16:02 UTC, Jan Beich
no flags Details | Diff
shebangfix (729 bytes, patch)
2014-09-03 16:05 UTC, Jan Beich
no flags Details | Diff
shebangfix (737 bytes, patch)
2014-09-03 16:07 UTC, Jan Beich
no flags Details | Diff
|poudriere testport -P| log (9.3R i386) (41.66 KB, text/plain)
2014-09-03 17:27 UTC, Jan Beich
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer 2014-09-03 16:02:08 UTC
Created attachment 146736 [details]
shebangfix

zsh support sh/bash emulation mode but it seems to disagree about quoting in regexp matches.

$ make install -C ${PORTSDIR:-/usr/local}/shells/zsh
$ ln -s /usr/local/bin/zsh ~/bin/bash
$ export PATH=~/bin:$PATH
$ make
...
===>  Configuring for pipelight-0.2.7.3_1
===>   FreeBSD 10 autotools fix applied to /cache/emulators/pipelight/work/mmueller2012-pipelight-79b1b7ba0032/configure
/bin/ln -s /dist/pipelight/pluginloader.tar.gz /cache/emulators/pipelight/work/mmueller2012-pipelight-79b1b7ba0032/pluginloader-v0.2.7.3.tar.gz
/bin/ln -s /dist/pipelight/pluginloader.tar.gz.sig /cache/emulators/pipelight/work/mmueller2012-pipelight-79b1b7ba0032/pluginloader-v0.2.7.3.tar.gz.sig
WARNING: Unknown argument --verbose.
WARNING: Unknown argument --x-libraries=/usr/local/lib.
WARNING: Unknown argument --x-includes=/usr/local/include.
WARNING: Unknown argument --build=amd64-portbld-freebsd11.0.
./configure:298: parse error near `('
===>  Script "configure" failed unexpectedly.

Test case:

$ bash --version | head -1
GNU bash, version 4.3.24(0)-release (amd64-portbld-freebsd11.0)
$ zsh --version
zsh 5.0.6 (amd64-portbld-freebsd11.0)

$ bash -f
$ [[ "foo(bar)" =~ foo\((bar)\) ]] && echo ${BASH_REMATCH[1]}
bar

$ zsh -f
% [[ "foo(bar)" =~ foo\((bar)\) ]] && echo ${BASH_REMATCH[1]}
% emulate -L bash
% [[ "foo(bar)" =~ foo\((bar)\) ]] && echo ${BASH_REMATCH[1]}
zsh: parse error near `('
% [[ "foo(bar)" =~ "foo\((bar)\)" ]] && echo ${BASH_REMATCH[1]}

% setopt bash_rematch
% [[ "foo(bar)" =~ "foo\((bar)\)" ]] && echo ${BASH_REMATCH[1]}
bar
Comment 1 Jan Beich freebsd_committer 2014-09-03 16:05:07 UTC
Created attachment 146737 [details]
shebangfix

Missed USES=shebangfix.
Comment 2 Jan Beich freebsd_committer 2014-09-03 16:07:45 UTC
Created attachment 146738 [details]
shebangfix

Doh, conflict with another change...
Comment 3 Jan Beich freebsd_committer 2014-09-03 17:27:46 UTC
Created attachment 146741 [details]
|poudriere testport -P| log (9.3R i386)

Builds fine sans unrelated strip/plist issues.
Comment 4 commit-hook freebsd_committer 2014-09-05 18:56:41 UTC
A commit references this bug:

Author: kmoore
Date: Fri Sep  5 18:56:06 UTC 2014
New revision: 367380
URL: http://svnweb.freebsd.org/changeset/ports/367380

Log:
  - Ignore bash from PATH

  PR: 193287
  Submitted by: Jan Beich <jbeich@vfemail.net>

Changes:
  head/emulators/pipelight/Makefile
Comment 5 Kris Moore freebsd_committer 2014-09-05 18:57:31 UTC
Committed, thanks!