Created attachment 146800 [details] new port shar file Seafile object module.
Created attachment 146801 [details] test port log
Created attachment 146802 [details] new port shar file
Review items: * DISTNAME, LICENSE, LICENSE_FILE commented out (leftovers). The last two need values. * Capitalize "Python" in COMMENT * GH_PROJECT already defaults to ${PORTNAME} * USE_PYTHON is deprecated, replace with USES (See Mk/Uses/python.mk) * pkg-plist is missing pyc and pyo files. These will be generated on first import, then leftover when user deinstalls. You need to run pycompile before installation. This patch needs updating before it can be committed. Please update according to this review, and all other review items in the other seafile new port submissions Thanks Jingfen!
Created attachment 146907 [details] portlint -AC output after updated shar file testing
Created attachment 146908 [details] diff from last shar
Created attachment 146909 [details] updated shar file
Most of Seafile project codes follow open source licenses, GPL, APACHE, MIT. I am confirming which license this code it follows. Will finalize with correct license information.
* GH_PROJECT is unnecessary (defaults to ${PORTNAME} in Mk/bsd.sites.mk) * Use git tags for GH_TAGNAME if they are available in the upstream repository
Created attachment 146939 [details] updated shar file correct license. Seafobj is part of Seahub project, which follows APACHE 2.0 license. Will attached email of confirmation.
Created attachment 146940 [details] diff from first shar to updated shar remove GH_PROJECT and correct TAGNAME, and LICENSE
Created attachment 147234 [details] shar file target commit clean out ~ file.
It is part of seahub comp, which follows the sea hub license APACHE2.0
same comments as other PR: 1) combine do-install and post-install 2) don't mask install commands with "@" 3) remove @dirrm* lines from pkg-plist moving back to triage so it doesn't get lost again.
Created attachment 149148 [details] shar file target commit - rm @ for non-mkdir - merge do-/post-install into do-install - re-gen pkg-plist
(In reply to Jingfeng Yan from comment #14) > Created attachment 149148 [details] > shar file target commit > > - rm @ for non-mkdir > - merge do-/post-install into do-install > - re-gen pkg-plist The last part of compile py to pyc, and pyo file has similar to py-seafdav. The original py modules do not have correct python pkg layout. Will see if this is changed from developer, or suggest them having formal one.
I'll take it. It's not "wrong", but I'll remove this line: X ${ECHO_MSG} "install script ... ${STAGEDIR}${PYTHON_SITELIBDIR} " It shows where it's getting installed in the log, right? The echo doesn't add value so I'll just remove it (same as py-seafdav)
(In reply to John Marino from comment #16) > I'll take it. > > It's not "wrong", but I'll remove this line: > X ${ECHO_MSG} "install script ... ${STAGEDIR}${PYTHON_SITELIBDIR} " > > It shows where it's getting installed in the log, right? The echo doesn't > add value so I'll just remove it (same as py-seafdav) It is fine to remove it. Thank you.
this looks wrong too: XGH_TAGNAME= v${PORTN}-server-testing (PORTVERSION, not PORTN) we'll find out in a minute.
confirmed problem and confirmed the fix.
It is generally bad practice to have the COMMENT and pkg-description the same. It normally means the pkg-description is inadequate.
I think we have been using the wrong WWW on all of these. for pkg-descr, http://seafile.com/en/home much better URL. The github is just the code which is already in MASTER_SITES anyway.
well, maybe that's not appropriate for this particular port. And I can't find a better description than you provided either.
A commit references this bug: Author: marino Date: Fri Nov 7 20:33:38 UTC 2014 New revision: 372297 URL: https://svnweb.freebsd.org/changeset/ports/372297 Log: Add new port www/py-seafobj PR: 193315 Submitted by: Jingfeng Yan full desc: "This is a Python library for accessing seafile data model." Unfortunately, that really is the most detailed description. All the README's are zero-bytes in the repo. Changes: head/www/Makefile head/www/py-seafobj/ head/www/py-seafobj/Makefile head/www/py-seafobj/distinfo head/www/py-seafobj/pkg-descr head/www/py-seafobj/pkg-plist
That's another one done.