Bug 193325 - games/tuxpaint-stamps: Update to version 2014.08.23
Summary: games/tuxpaint-stamps: Update to version 2014.08.23
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Pawel Pekala
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-04 19:04 UTC by tkato432
Modified: 2014-09-21 12:06 UTC (History)
2 users (show)

See Also:

Attachments
games_tuxpaint-stamps.diff (612.88 KB, patch)
2014-09-04 19:04 UTC, tkato432 		no flags Details | Diff
games_tuxpaint-stamps.log (758 bytes, text/x-log)
2014-09-06 19:12 UTC, tkato432 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description tkato432 2014-09-04 19:04:49 UTC 
Created attachment 146824 [details]
games_tuxpaint-stamps.diff
Comment 1 Marcus von Appen freebsd_committer freebsd_triage 2014-09-05 21:59:05 UTC 
Can you please provide some more information about the test of the port, by either

a) providing the logs of a "poudriere testport" or "poudriere bulk -t" run OR
b) "make check-plist" followed by "make stage-qa" output  (https://www.freebsd.org/doc/en/books/porters-handbook/porting-testing.html)

and also provide the output of portlint -AC? Thanks!
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2014-09-06 05:27:48 UTC 
Additionally, 

 * Add LICENSE_FILE
Comment 3 tkato432 2014-09-06 19:12:33 UTC 
Created attachment 146964 [details]
games_tuxpaint-stamps.log
Comment 4 Marcus von Appen freebsd_committer freebsd_triage 2014-09-08 06:20:05 UTC 
Is DATA_PREFIX only used for installation or is it referenced in the code and application, too? If the latter is the case, the application would try to look for data files in the stage dir, which is not correct.

+ MAKE_ARGS=	DATA_PREFIX="${STAGEDIR}${DATADIR}/"

Can you clarify this, tkato?
Comment 5 tkato432 2014-09-08 18:30:33 UTC 
I suppose stage-qa ensures that STAGEDIR string is not remained in the
package.

Actually, DISTFILES of this port consists entirely of arch-independent
data files and installation is simply unpacking and copying those into
destination directory. It seems there is no possibility of pathname
contamination.
Comment 6 Marcus von Appen freebsd_committer freebsd_triage 2014-09-09 05:19:08 UTC 
Patch and log look good, moving to patch ready.
Comment 7 commit-hook freebsd_committer freebsd_triage 2014-09-21 12:05:40 UTC 
A commit references this bug:

Author: pawel
Date: Sun Sep 21 12:05:28 UTC 2014
New revision: 368744
URL: http://svnweb.freebsd.org/changeset/ports/368744

Log:
  - Update to version 2014.08.23
  - Add LICENSE

  PR:		ports/193325
  Submitted by:	tkato432@yahoo.com

Changes:
  head/games/tuxpaint-stamps/Makefile
  head/games/tuxpaint-stamps/distinfo
  head/games/tuxpaint-stamps/pkg-descr
  head/games/tuxpaint-stamps/pkg-plist