Created attachment 146904 [details] net/balance [request maintainer] STAGE LICENSE net/balance adds STAGE, LICENSE, MAINTAINER modifies pkg-plist Please see 2014-09-03.diff, for details. See also net-balance-tests-out, (requisite QA tests) also attached. Thank you for all your time, and consideration. --Chris
Created attachment 146905 [details] net/balance requisite QA for 2014-09-03.diff net/balance Please find net-balance-tests-out, attached. For requisite QA log, for 2014-09-03.diff, also attached. --Chris
Initial review: * MAINTAINER: portmaster@FreeBSD.org - incorrect domain * Add LICENSE_FILE if a standalone license file exists in distribution files
Created attachment 146956 [details] net/balance [request maintainer] STAGE LICENSE net/balance OBSOLETES previous (bone headed mistakes) adds LICENSE, MAINTAINER modifies LICENSE (GPLv1 ==> GPLv2) See also requisite QA (net-balance-QA), also attached. Thanks, and sorry for the previous MAINTAINER screw up. --Chris
Created attachment 146957 [details] net/balance QA output for 2014-09-05.diff net/balance Requisite QA, for 2014-09-05.diff, also attached. --Chris
(In reply to Kubilay Kocak from comment #2) > Initial review: > > * MAINTAINER: portmaster@FreeBSD.org - incorrect domain > * Add LICENSE_FILE if a standalone license file exists in distribution files P.S. I chose LICENSE, over LICENSE_FILE(s), because in this version -- 3.5.4, COPYING (included in the source tarball), is an exact copy of GPLv2. So [to me, anyway] it seemed the same. No? Thanks again, Kubilay. --Chris
Most of the lines that changed should not have changed. They are whitespace changes caused by your editor being set to tabs widths that are not 8. Also, the @unexec change to pkg-plist is debatable. It should probably stay at rmdir rather than rm -rf.
@Chris As I can see this port was removed 8 months ago during the stage campaign. If you want we can resurrect it. I gonna make a shar file based on your patches and attach it to the PR. Please take a look, fix it if needed, in order to do a proper commit. - rodrigo
Created attachment 150977 [details] Suggested shar file to resurrect net/balance Here comes the shar file for the newest balance port, please test it and make changes if required.
last call before closure (reporter TO)
Created attachment 151741 [details] net/balance UPDATED/CORRECTED, and FINAL submission for the port's revival
(In reply to Rodrigo Osorio from comment #9) For reasons unknown, I never received alerts to your previous messages/comments regarding this port, Rodrigo. In any event, I was unable to work with the shar(1) file you created. It appeared to actually be several individual shar files cat(1)'d together. In any event, I created a new shar attachment. It is complete, and you should find it meets all the necessary standards required to revive the port; net/balance. Thank you for all your time, and consideration, Rodrigo. --Chris
Thanks for the shar everything looks OK to me exept last version is 3.56, not 3.54. Changing PORTVERSION seems to be enough, the port compiles file. I will attach the updated shar, if it's ok to you, I'll commit
Created attachment 152182 [details] net/balance v3.56
Created attachment 152184 [details] net/balance v3.56
Looks good to me, Rodrigo. Thank you! --Chris
Not sure if this makes any difference. But shouldn't the shar(1) file *only* carry the *port directory*, not the category directory? I see your shar also includes the category directory. Just thought I'd mention it. --Chris
Created attachment 152202 [details] The net/balance shar(1) without category directory included. The net/balance shar(1) without category directory included.
(In reply to Chris Hutchinson from comment #16) > Not sure if this makes any difference. But shouldn't the shar(1) file *only* carry the *port directory*, not the category directory? The porter handbook refers to a shar without category, but doesn't really matter to me. Ready for commit.
(In reply to Rodrigo Osorio from comment #18) OK, good. Thanks, Rodrigo. --Chris
A commit references this bug: Author: rodrigo Date: Mon Jan 26 22:04:41 UTC 2015 New revision: 377961 URL: https://svnweb.freebsd.org/changeset/ports/377961 Log: Resurect net/balance, a generic TCP proxy with round robin features PR: 193368 Submitted by: Chris Hutchinson <portmaster@bsdforge.com> Changes: head/net/Makefile head/net/balance/ head/net/balance/Makefile head/net/balance/distinfo head/net/balance/files/ head/net/balance/files/balance.in head/net/balance/pkg-descr head/net/balance/pkg-plist
committed, thanks