Bug 193373 - [PATCH] audio/xanalyser: Does not use appropriate OSS IOCTLs
Summary: [PATCH] audio/xanalyser: Does not use appropriate OSS IOCTLs
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Kurt Jaeger
URL:
Keywords: easy, patch-ready
Depends on:
Blocks:
 
Reported: 2014-09-06 08:44 UTC by Hans Petter Selasky
Modified: 2018-09-03 18:22 UTC (History)
3 users (show)

See Also:
pi: maintainer-feedback+

Attachments
Fix for problem. (452 bytes, patch)
2014-09-06 08:44 UTC, Hans Petter Selasky 		koobs: maintainer-approval? (db)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hans Petter Selasky freebsd_committer freebsd_triage 2014-09-06 08:44:33 UTC 
Created attachment 146906 [details]
Fix for problem.

Hi,

SNDCTL_DSP_GETBLKSIZE() is in FreeBSD a read only IOCTL.
Need to use SNDCTL_DSP_SETBLKSIZE() to really set the blocksize.

Thank you!

--HPS
Comment 1 Diane Bruce freebsd_committer freebsd_triage 2014-09-08 20:41:46 UTC 
If someone has it ready for commit please just commit. ;)
Comment 2 Walter Schwarzenfeld freebsd_triage 2018-01-10 21:37:37 UTC 
source shows still
int tmp_buffer_size = want_buffer_size;
    if (ioctl (fd, SNDCTL_DSP_GETBLKSIZE, &tmp_buffer_size) == -1) {
        cerr << "error " << strerror (errno) << '\n';
        return;
    }

but is this still relevant?
Comment 3 Kurt Jaeger freebsd_committer freebsd_triage 2018-09-03 14:25:57 UTC 
testbuilds@work
Comment 4 Hans Petter Selasky freebsd_committer freebsd_triage 2018-09-03 15:41:36 UTC 
The patch fixes an issue, but it should go upstream I guess.

I'm not using this utility at the moment, so if you want to abandon this case I'm fine.

--HPS
Comment 5 commit-hook freebsd_committer freebsd_triage 2018-09-03 18:20:49 UTC 
A commit references this bug:

Author: pi
Date: Mon Sep  3 18:20:23 UTC 2018
New revision: 478887
URL: https://svnweb.freebsd.org/changeset/ports/478887

Log:
  audio/xanalyser: fix a ioctl call

  - SNDCTL_DSP_GETBLKSIZE() is in FreeBSD a read only ioctl()
    Need to use SNDCTL_DSP_SETBLKSIZE() to really set the blocksize.

  PR:		193373
  Submitted by:	hselasky
  Reviewed by:	Walter Schwarzenfeld <w.schwarzenfeld@utanet.at>
  Approved by:	db (maintainer)

Changes:
  head/audio/xanalyser/Makefile
Comment 6 Kurt Jaeger freebsd_committer freebsd_triage 2018-09-03 18:21:46 UTC 
Committed, thanks
Comment 7 commit-hook freebsd_committer freebsd_triage 2018-09-03 18:21:52 UTC 
A commit references this bug:

Author: pi
Date: Mon Sep  3 18:21:27 UTC 2018
New revision: 478888
URL: https://svnweb.freebsd.org/changeset/ports/478888

Log:
  audio/xanalyser: fix a ioctl call (now for real)

  - SNDCTL_DSP_GETBLKSIZE() is in FreeBSD a read only ioctl()
    Need to use SNDCTL_DSP_SETBLKSIZE() to really set the blocksize.

  PR:           193373
  Submitted by: hselasky
  Reviewed by:  Walter Schwarzenfeld <w.schwarzenfeld@utanet.at>
  Approved by:  db (maintainer)

Changes:
  head/audio/xanalyser/files/patch-src_pcm-oss.cc