Bug 193404 - comms/gqrx: Update to 2.3.1
Summary: comms/gqrx: Update to 2.3.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: Bartek Rutkowski
URL:
Keywords: easy, patch
Depends on:
Blocks:
 
Reported: 2014-09-06 23:43 UTC by Kevin Zheng
Modified: 2014-10-25 15:04 UTC (History)
2 users (show)

See Also:

Attachments
Update to 2.3.1 (4.08 KB, patch)
2014-09-06 23:43 UTC, Kevin Zheng 		no flags Details | Diff
Poudriere build log on 10amd64 (4.08 KB, text/plain)
2014-09-07 14:29 UTC, Kevin Zheng 		no flags Details
Poudriere build log on 10amd64 (175.81 KB, text/plain)
2014-09-07 14:31 UTC, Kevin Zheng 		no flags Details
Update to 2.3.1 (take 2) (4.27 KB, patch)
2014-10-21 13:47 UTC, Ganael LAPLANCHE 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Zheng 2014-09-06 23:43:19 UTC 
Created attachment 146973 [details]
Update to 2.3.1

Gqrx is available via Github, so instead of pointing to a local mirror of the sources switch to actual releases from the upstream developer.

 - Update to 3.2.1, bumping PORTEPOCH
 - Update COMMENT and pkg-descr
 - Add LICENSE_FILE
 - Remove Boost dependency
 - Install desktop file
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2014-09-07 11:15:03 UTC 
Thanks for your submission Kevin

If possible, please also include the following the ensure timely resolution:

 * Attach successful poudriere testport, or redports.org build logs
 * portlint -AC output (after addressing any outstanding issues)
Comment 2 Kevin Zheng 2014-09-07 14:29:34 UTC 
Created attachment 147010 [details]
Poudriere build log on 10amd64
Comment 3 Kevin Zheng 2014-09-07 14:31:10 UTC 
Created attachment 147011 [details]
Poudriere build log on 10amd64

Oops, attached the wrong file.
Comment 4 Kevin Zheng 2014-09-07 14:33:21 UTC 
I've attached my poudriere build log. The resulting package runs and is able to collect and analyze IQ samples from an rtl-sdr.

`portlint -AC` output:

WARN: Makefile: new ports should not set PORTEPOCH.
WARN: Consider to set DEVELOPER=yes in /etc/make.conf
0 fatal errors and 2 warnings found.
Comment 5 Kubilay Kocak freebsd_committer freebsd_triage 2014-09-07 14:49:10 UTC 
Great work Kevin :)

Minor nit:

 * Strip trailing slash from pkg-descr WWW: URL
Comment 6 Bartek Rutkowski freebsd_committer freebsd_triage 2014-10-18 08:57:59 UTC 
Requesting approval from port maintainer.
Comment 7 Ganael LAPLANCHE freebsd_committer freebsd_triage 2014-10-21 13:45:24 UTC 
Hi Kevin,

Thanks for your submission. The patch looks good to me, except that a PORTREVISION has been introduced to gqrx meanwhile. Find attached an updated version of the patch that includes that change, as well as removes the trailing slash from WWW: in pkg-descr.

Bartek, as you own the PR, I'll let you commit it ; it is OK for me :)

Best regards,
Ganael.
Comment 8 Ganael LAPLANCHE freebsd_committer freebsd_triage 2014-10-21 13:47:27 UTC 
Created attachment 148537 [details]
Update to 2.3.1 (take 2)
Comment 9 Bartek Rutkowski freebsd_committer freebsd_triage 2014-10-24 11:20:35 UTC 
Seems like it will have to wait a while - so far I havent managed to build it properly even once, not only it takes a huge amount of time and packages to build, but also several dependencies are failing to build, and I wont commit it without a successful build log.
Comment 10 commit-hook freebsd_committer freebsd_triage 2014-10-25 15:03:58 UTC 
A commit references this bug:

Author: robak
Date: Sat Oct 25 15:03:14 UTC 2014
New revision: 371486
URL: https://svnweb.freebsd.org/changeset/ports/371486

Log:
  comms/gqrx: update 20140313 -> 2.3.1

  - Set PORTEPOCH
  - Update COMMENT and pkg-descr
  - Add LICENSE_FILE
  - Remove obsolete dependency
  - Mantainer approved

  PR:		193404
  Submitted by:	Kevin Zheng <kevinz5000@gmail.com>
  Reviewed by:	martymac (maintainer)
  Approved by:	mentors (implicit), martymac (maintainer)

Changes:
  head/comms/gqrx/Makefile
  head/comms/gqrx/distinfo
  head/comms/gqrx/files/patch-gqrx.pro
  head/comms/gqrx/pkg-descr
Comment 11 Bartek Rutkowski freebsd_committer freebsd_triage 2014-10-25 15:04:49 UTC 
Committed, thanks for your work!