Bug 193425 - [MAINTAINER] science/jstrack: Fix BROKEN
Summary: [MAINTAINER] science/jstrack: Fix BROKEN
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: Normal Affects Only Me
Assignee: John Marino
URL:
Keywords: easy, patch
Depends on:
Blocks:
 
Reported: 2014-09-07 12:25 UTC by Muhammad Moinur Rahman
Modified: 2014-09-25 17:16 UTC (History)
1 user (show)

See Also:


Attachments
patch for jstrack-3.3.4 (5.46 KB, patch)
2014-09-07 12:25 UTC, Muhammad Moinur Rahman
bofh: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Muhammad Moinur Rahman freebsd_committer freebsd_triage 2014-09-07 12:25:25 UTC
Created attachment 147002 [details]
patch for jstrack-3.3.4

- Fix BROKEN

Upstream changed the distfiles without bumping port version for removing some old data from the distfiles. 

Snippet from my mail with the author:
> Did you recently change the distfile without bumping version number? I
> will fix it but prior to that I need to know the proper reason.

Yes.  I don't remember exactly what it was, but it was a simple issue
with the archive file itself.  So I fixed that.  I definitely know
there were no changes to JStrack---I always change the version number
if I add a patch or add new features.

As for the "proper reason", if I see a need to patch something in the
distribution, say, add storm data that I'd forgotten to add previously,
move storm data from storms to storms/old/YEAR/..., etc., I do it.  I
don't change the version number unless there's a change to JStrack's
code (which obviously includes the filters for NHC data).  If it's
2014, and I see that there is 2013 code in the storms directory in the
dist file, I fix that.  And so on.....  Those are more than enough of
a "proper reason" for me.  :-)

Poudriere logs:
http://pdr.s.ubze.ro/bulk/latest-per-pkg/jstrack/3.3.4/
Comment 1 commit-hook freebsd_committer freebsd_triage 2014-09-25 16:53:59 UTC
A commit references this bug:

Author: marino
Date: Thu Sep 25 16:53:44 UTC 2014
New revision: 369274
URL: http://svnweb.freebsd.org/changeset/ports/369274

Log:
  science/jstrack: Unbreak; author verified distfile was rerolled

  PR:		193425
  Submitted by:	Muhammad Rahman

  While here, remove redundant @dirrm from pkg-plist

Changes:
  head/science/jstrack/Makefile
  head/science/jstrack/distinfo
  head/science/jstrack/pkg-plist
Comment 2 John Marino freebsd_committer freebsd_triage 2014-09-25 17:16:40 UTC
Thanks!