Created attachment 147033 [details] icc-8.1.038_2.diff - Clean-up Makefile - Rename some patches according to portlint - Fix WWW in pkg-descr - Fix pkg-plist - Take maintainership
Thank you for your submission and for taking maintainership of this port Carlos. If possible please also include the following QA results to promote quick resolution: * Attach successful poudriere testport, or redports.org build logs * portlint -AC output (after addressing any outstanding issues)
Build logs via poudriere on 8.4-i386, 9.2-i386 and 10.0-i386 https://fbsd.es/~cpm/freebsd/poudriere/freebsd:8:x86:32/icc-8.1.038_2.log https://fbsd.es/~cpm/freebsd/poudriere/freebsd:9:x86:32/icc-8.1.038_2.log https://fbsd.es/~cpm/freebsd/poudriere/freebsd:10:x86:32/icc-8.1.038_2.log portlint -AC output: WARN: Makefile: [58]: IGNORE messages should begin with a lowercase letter and end without a period. WARN: Makefile: possible use of absolute pathname "/usr/include/c++/${G...". WARN: Makefile: possible use of absolute pathname "/usr/lib/${f}". WARN: Makefile: possible direct use of "work" " @${ECHO} "Please use FreeBSD as the name of your OS in communications with the support, the larger the FreeBSD userbase is, the more work gets done on FreeBSD specific issues by Intel. And please thank them for the FreeBSD support, they are already spending some time to improve icc on FreeBSD." | fmt" found. if so, use ${WRKDIR} instead. WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy. WARN: Makefile: new ports should not set PORTREVISION. WARN: Makefile: no MASTER_SITES found. is it ok? WARN: Makefile: use of DISTFILES with single file discouraged. distribution filename should be set by DISTNAME and EXTRACT_SUFX. WARN: Makefile: Consider defining LICENSE. WARN: Makefile: "EXTRACT_DEPENDS" has to appear earlier. WARN: Makefile: "PATCH_DEPENDS" has to appear earlier. WARN: Makefile: do not use DISTFILES and DISTNAME to control WRKSRC. how about "WRKSRC=${WRKDIR}/l_cc_pc_${PORTVERSION:C/p.+$//}"? WARN: Makefile: "RESTRICTED" found. do not forget to update ports/LEGAL. WARN: Consider to set DEVELOPER=yes in /etc/make.conf 0 fatal errors and 14 warnings found.
Asking for poudriere is a bit heavy for these types of changes, but portlint output is interesting. It seems like you could make minor changes to silence several of those warnings. Perhaps you can take another look? It keeps saying "new port". Are these messages bogus based on where your port is located? If so, can you put it in a tree that gives the true messages? (poudriere testport might show portlint as well, but I can't remember for sure)
Created attachment 147245 [details] icc-8.1.038_2.diff Now it looks better. what do you think? % portlint -ac WARN: Makefile: [91]: possible use of "${CHMOD}" found. Use @owner/@group operators in pkg-plist instead. WARN: Makefile: possible use of absolute pathname "/usr/include/c++/${G...". WARN: Makefile: possible use of absolute pathname "/usr/lib/${f}". WARN: Makefile: possible direct use of "work" " ${ECHO} "Please use FreeBSD as the name of your OS in communications with the support, the larger the FreeBSD userbase is, the more work gets done on FreeBSD specific issues by Intel. And please thank them for the FreeBSD support, they are already spending some time to improve icc on FreeBSD." | fmt" found. if so, use ${WRKDIR} instead. WARN: Makefile: use of DISTFILES with single file discouraged. distribution filename should be set by DISTNAME and EXTRACT_SUFX. WARN: Makefile: "PATCH_DEPENDS" has to appear earlier. WARN: Makefile: do not use DISTFILES and DISTNAME to control WRKSRC. how about "WRKSRC=${WRKDIR}/l_cc_pc_${PORTVERSION:C/p.+$//}"? WARN: Makefile: "RESTRICTED" found. do not forget to update ports/LEGAL. WARN: Consider to set DEVELOPER=yes in /etc/make.conf 0 fatal errors and 9 warnings found.
it's a little better (i probably would have removed "work" from that long line just to just up portlint, but that's just me) I didn't mean to move it to patch ready before, but now it's okay to be there.
Created attachment 147257 [details] icc-8.1.038_2.diff I reduced it from 9 warnings to 8 warnings. % portlint -ac WARN: Makefile: [91]: possible use of "${CHMOD}" found. Use @owner/@group operators in pkg-plist instead. WARN: Makefile: possible use of absolute pathname "/usr/include/c++/${G...". WARN: Makefile: possible use of absolute pathname "/usr/lib/${f}". WARN: Makefile: use of DISTFILES with single file discouraged. distribution filename should be set by DISTNAME and EXTRACT_SUFX. WARN: Makefile: "PATCH_DEPENDS" has to appear earlier. WARN: Makefile: do not use DISTFILES and DISTNAME to control WRKSRC. how about "WRKSRC=${WRKDIR}/l_cc_pc_${PORTVERSION:C/p.+$//}"? WARN: Makefile: "RESTRICTED" found. do not forget to update ports/LEGAL. WARN: Consider to set DEVELOPER=yes in /etc/make.conf 0 fatal errors and 8 warnings found.
A commit references this bug: Author: riggs Date: Sun Sep 14 17:21:28 UTC 2014 New revision: 368201 URL: http://svnweb.freebsd.org/changeset/ports/368201 Log: - Assign maintainership to Carlos Jacobo Puga Medina <cpm@fbsd.es> - Add RESTRICTED, LICENSE - Clean up Makefile - Retire post-install - Use pkg-message - Rename patches according to the naming conventions PR: 193446 Submitted by: cpm@fbsd.es Reviewed by: marino, riggs Changes: head/lang/icc/Makefile head/lang/icc/files/patch-include::c++::cstdio head/lang/icc/files/patch-include::c++::cstdlib head/lang/icc/files/patch-include::c++::cwchar head/lang/icc/files/patch-include::c++::yvals.h head/lang/icc/files/patch-include__c++__cstdio head/lang/icc/files/patch-include__c++__cstdlib head/lang/icc/files/patch-include__c++__cwchar head/lang/icc/files/patch-include__c++__yvals.h head/lang/icc/files/pkg-message.in head/lang/icc/pkg-descr head/lang/icc/pkg-plist
Thanks for taking maintainership and working on the port, Carlos! For the record: I moved the essay from the post-install target into pkg-message.in.