Created attachment 147143 [details] shar QuickFix is open source FIX protocol implementation WWW: http://www.quickfixengine.org/ Build logs: https://redports.org/buildarchive/20140907233806-22706/
Nevermind. I just discovered a several issues with the port. Working to fix them now
Created attachment 147277 [details] fixed port fixed python support fixed -lcompat issue fixed shared lib installation
1) you are masking the post-install strip command with "@", so remove that character 2) do you have any poudriere logs proving this new port has been properly tested? e.g. poudriere must perform stage-qa checks
Created attachment 149094 [details] latest port - Removed @ char before $STRIP_CMD
Currently I do not have build logs with stage-qa as redports.org does not support it. Although I can provide logs from my own build server in a next few days.
1) Port build fails when Ruby option is on, please see log: http://people.freebsd.org/~pawel/buildlogs/quickfix-1.14.0.log 2) USE_PYTHON is old, please convert to USES=python 3) Options block should be last, after build|lib|run depends then USES, HAS_CONFIGURE, USE_* etc Other than that port seems to build on all supported release nicely.
Created attachment 149552 [details] fixed port Thanks for feedback Updated port attached. Changes: - Fixed ruby support - reorder Makefile - Cleanup plist And the last: I do not have any usage of USE_PYTHON.
Ruby options fails with plist errors: ====> Running Q/A tests (stage-qa) ====> Checking for pkg-plist issues (check-plist) ===> Parsing plist ===> Checking for items in STAGEDIR missing from pkg-plist Error: Orphaned: %%DATADIR%%/quickfix40.rb Error: Orphaned: %%DATADIR%%/quickfix41.rb Error: Orphaned: %%DATADIR%%/quickfix42.rb Error: Orphaned: %%DATADIR%%/quickfix43.rb Error: Orphaned: %%DATADIR%%/quickfix44.rb Error: Orphaned: %%DATADIR%%/quickfix50.rb Error: Orphaned: %%DATADIR%%/quickfix50sp1.rb Error: Orphaned: %%DATADIR%%/quickfix50sp2.rb Error: Orphaned: %%DATADIR%%/quickfix_fields.rb Error: Orphaned: %%DATADIR%%/quickfix_ruby.rb Error: Orphaned: %%DATADIR%%/quickfixt11.rb ===> Checking for items in pkg-plist which are not in STAGEDIR ===> Error: Plist issues found. *** Error code 1 This is strange files are already installed in RUBY_SITELIBDIR.
Sorry for very long response. I have missed your comment. It seems that install target puts these files both under SITE_RUBY and DATADIR. I Fixed plist to reflect that.
Created attachment 158773 [details] fixed port
Build log: http://pkg.tsatsenko.ru/logs/bulk/101amd64-default/2015-07-15_01h42m31s/logs/quickfix-1.14.0.log The port above has RUBY enabled by default for test builds. I am doubt we need it enabled by default in ports tree. I will submit final version without RUBY enabled by default.
No promised final version timeout.
I am sorry. Somehow I have missed that PR. And yes I am still interested in bringing the software to the ports tree. Right now I am running poudriere to ensure that the port doesnt have any build/install issues
Created attachment 172031 [details] latest port - Update to 1.14.3 - Modernize a bit - Disable by default all of the options except MYSQL QA: poudriere 103amd64 - OK (with both all options enabled and disabled) portlint - no errors
.if ${PORT_OPTIONS:MRUBY} ${STRIP_CMD} ${STAGEDIR}${RUBY_SITELIBDIR}/quickfix.so .endif This should be done in post-install target, right? Build fails on 9: http://people.freebsd.org/~pawel/buildlogs/quickfix-1.14.3-9amd64.log There is problem in install phase when PYTHON=on: http://people.freebsd.org/~pawel/buildlogs/quickfix-1.14.3-10amd64.log
Hello Thanks for feedback. I have fixed STRIP_CMD and build on 9.x issues. However I failed to reproduce python related problem. Will try again tomorrow.
Created attachment 177835 [details] the port - Fix build on 9.x - Fix STRIP_CMD - Fix python related issue
Any advance here?
Hello. I have corrected all of the known issues. No any action since then
testbuilds@work
fails to build on current (12amd64), see http://people.freebsd.org/~pi/logs/finance__quickfix-cur-1515864999.txt builds fine on 10.3-i386. Testing on 11.1 pending other compile job.
btw, I added USES=iconv
Builds also fine on 10.4 amd64.
Hello, Thanks for running testbuilds. Regarding 12-CURRENT since I dont have access to a running CURRENT box at the moment I'd suggest to mark it broken on 12.x with an intention to address the issue later on. Most likely when it reaches BETA stage. Thanks!
I think I found a build-fix.
A commit references this bug: Author: pi Date: Sun Feb 25 19:33:58 UTC 2018 New revision: 462973 URL: https://svnweb.freebsd.org/changeset/ports/462973 Log: New port: finance/quickfix The Financial Information Exchange (FIX) Protocol is a message standard developed to facilitate the electronic exchange of information related to securities transactions. It is intended for use between trading partners wishing to automate communications. QuickFIX is a free and open source implementation of the FIX protocol. WWW: http://www.fixprotocol.org/ WWW: http://www.quickfixengine.org/ PR: 193504 Submitted by: Mikhail Tsatsenko <m.tsatsenko@gmail.com> Reviewed by: marino, pawel, w.schwarzenfeld@utanet.at Changes: head/finance/Makefile head/finance/quickfix/ head/finance/quickfix/Makefile head/finance/quickfix/distinfo head/finance/quickfix/files/ head/finance/quickfix/files/patch-configure head/finance/quickfix/files/patch-src-python-Makefile.in head/finance/quickfix/files/patch-src-ruby-Makefile.in head/finance/quickfix/pkg-descr head/finance/quickfix/pkg-plist
Committed, thanks for your patience!