Bug 193536 - [patch] www/mod_authnz_crowd build against apache22/24
Summary: [patch] www/mod_authnz_crowd build against apache22/24
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Vick Khera
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-10 18:47 UTC by Olli Hauer
Modified: 2014-10-15 20:45 UTC (History)
1 user (show)

See Also:


Attachments
fix build against apache22/24 (4.86 KB, patch)
2014-09-10 18:47 UTC, Olli Hauer
no flags Details | Diff
proper patch to build against apache 2.4 and svn 1.8 (11.84 KB, patch)
2014-10-14 15:16 UTC, Vick Khera
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Olli Hauer freebsd_committer freebsd_triage 2014-09-10 18:47:13 UTC
Created attachment 147185 [details]
fix build against apache22/24

Allow www/mod_authnz_crowd build against apache22 and apache24.

Please test if the port also works as expected if build against apache24
Comment 1 Vick Khera 2014-09-12 19:17:45 UTC
Comment on attachment 147185 [details]
fix build against apache22/24

My hunch is that it will not work with Apache 2.4. There is this pull request with upstream source project to incorporate the necessary fixes, and they are fairly more complicated than this patch.

https://bitbucket.org/atlassian/cwdapache/pull-request/18/added-apache-24-compatibility-and-fixed/diff

That said, I will try to set up a test environment to run this proposed patch in Apache 2.4 in the next week or so, as work permits.
Comment 2 Olli Hauer freebsd_committer freebsd_triage 2014-09-13 09:46:28 UTC
Oh yes, seems it also requires fixes for subversion 1.7/1.8.
I have only looked for changed Apache API's, and suspect it was building fine since I have devel/subversion17 on my dev system.
Comment 3 Vick Khera 2014-10-14 15:16:23 UTC
Created attachment 148301 [details]
proper patch to build against apache 2.4 and svn 1.8

I merged patches from the URL above to make this software build with Apache 2.4 (keeping 2.2 compatibility) and subversion 1.8 (keeping older compatibility). Those are included in the attached patch.

I also updated the port to include the .0.0.0 shared libs. I don't know what changed to make the build process suddenly start building these and symlinking the .so to those, but that is handled as well.
Comment 4 Vick Khera 2014-10-14 15:18:46 UTC
This updated patch obsoletes https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=194351
Comment 5 commit-hook freebsd_committer freebsd_triage 2014-10-14 20:14:02 UTC
A commit references this bug:

Author: ohauer
Date: Tue Oct 14 20:13:32 UTC 2014
New revision: 370882
URL: https://svnweb.freebsd.org/changeset/ports/370882

Log:
  - fix build with apache24
  - fix build with subversion 1.8.x

  PR:		193536
  Submitted by:	ohauer
  Approved by:	Vick Khera (maintainer)
  Obtained from:	https://bitbucket.org/atlassian/cwdapache/pull-request/18/added-apache-24-compatibility-and-fixed/diff [2]
  MFH:		2014Q3

  [1] fix shaped and tested by Vick Khera
  [2] based on

Changes:
  head/www/mod_authnz_crowd/Makefile
  head/www/mod_authnz_crowd/files/patch-configure.ac
  head/www/mod_authnz_crowd/files/patch-src__Makefile.am
  head/www/mod_authnz_crowd/files/patch-src__apache24_svn18
  head/www/mod_authnz_crowd/files/patch-src__svn__Makefile.am
  head/www/mod_authnz_crowd/pkg-descr
Comment 6 Vick Khera 2014-10-15 11:48:53 UTC
Can this get merged back into the quarterly ports snapshots. I'm still getting complaints from the package build clusters for those. And there seem to be a lot of them! :(

Thanks!
Comment 7 Olli Hauer freebsd_committer freebsd_triage 2014-10-15 12:00:21 UTC
Hi Vick,

sure this was my planning, sadly I used the wrong MFH tag (2014Q3 instead 2014Q4).
I will contact portmgr@ to get a green light for the merge.
Comment 8 commit-hook freebsd_committer freebsd_triage 2014-10-15 20:45:07 UTC
A commit references this bug:

Author: ohauer
Date: Wed Oct 15 20:44:42 UTC 2014
New revision: 370952
URL: https://svnweb.freebsd.org/changeset/ports/370952

Log:
  MFH: r370882

  - fix build with apache24
  - fix build with subversion 1.8.x

  PR:		193536
  Submitted by:	ohauer
  Approved by:	Vick Khera (maintainer)
  Obtained from:	https://bitbucket.org/atlassian/cwdapache/pull-request/18/added-apache-24-compatibility-and-fixed/diff [2]

  [1] fix shaped and tested by Vick Khera
  [2] based on

  Approved by:	portmgr (mat)

Changes:
_U  branches/2014Q4/
  branches/2014Q4/www/mod_authnz_crowd/Makefile
  branches/2014Q4/www/mod_authnz_crowd/files/patch-configure.ac
  branches/2014Q4/www/mod_authnz_crowd/files/patch-src__Makefile.am
  branches/2014Q4/www/mod_authnz_crowd/files/patch-src__apache24_svn18
  branches/2014Q4/www/mod_authnz_crowd/files/patch-src__svn__Makefile.am
  branches/2014Q4/www/mod_authnz_crowd/pkg-descr