Bug 193552 - www/mod_log_config-st [maintainer] support for recent apache.mk PATCH
Summary: www/mod_log_config-st [maintainer] support for recent apache.mk PATCH
Status: Closed Not A Bug
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Philip M. Gollucci
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-11 06:19 UTC by Chris Hutchinson
Modified: 2015-08-18 22:57 UTC (History)
2 users (show)

See Also:


Attachments
www/mod_log_config-st comply w/new apache.mk (567 bytes, patch)
2014-09-11 06:19 UTC, Chris Hutchinson
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Hutchinson 2014-09-11 06:19:51 UTC
Created attachment 147210 [details]
www/mod_log_config-st comply w/new apache.mk

www/mod_log_config-st

adds necessary support for recent changes to apache.mk
bumps PORTREVISION

Please see 2014-09-10.diff, attached, for details.

Thank you for all your time, and consideration.

--Chris
Comment 1 Olli Hauer freebsd_committer freebsd_triage 2014-09-13 10:10:35 UTC
Seems a patch to build against apache24 is missing

===>  Building for ap24-mod_log_config-st-1.03_3
/usr/local/share/apr/build-1/libtool --silent --mode=compile cc -std=gnu99 -prefer-pic -O2 -pipe -I/usr/include -fno-strict-aliasing    -I/usr/local/include/apache24  -I/usr/local/include/apr-1   -I/usr/local/include/apr-1 -I/usr/include -I/usr/local/include -I/usr/local/include/db5  -c -o mod_log_config.lo mod_log_config.c && touch mod_log_config.slo
mod_log_config.c: In function 'log_remote_address':
mod_log_config.c:362: error: 'conn_rec' has no member named 'remote_ip'
mod_log_config.c: In function 'log_pid_tid':
mod_log_config.c:591: warning: assignment makes integer from pointer without a cast
mod_log_config.c: In function 'ap_filepipe_log_ewriter':
mod_log_config.c:1566: warning: passing argument 3 of 'apr_file_write' from incompatible pointer type
apxs:Error: Command failed with rc=65536
Comment 2 John Marino freebsd_committer freebsd_triage 2014-10-08 18:17:39 UTC
poudriere log on next update, please.
Moving to "open" since it's known to be a bad patch.
Comment 3 Philip M. Gollucci freebsd_committer freebsd_triage 2015-08-18 22:03:57 UTC
Take.
Comment 4 Chris Hutchinson 2015-08-18 22:57:24 UTC
(In reply to Philip M. Gollucci from comment #3)
> Take.

D'OH! I *completely* forgot about this one.
The apache.mk has changed several times since this pr(1)
was created. I haven't run into any troubles with
www/mod_log_config-st since. Nor has anyone else
indicated they had any troubles.

As such. I think we can safely close this.

Sorry for not addressing this sooner!

--Chris