Bug 193633 - [PATCH] net/miniupnpd - Fix compilation on -HEAD r270870+ and overall improvement
Summary: [PATCH] net/miniupnpd - Fix compilation on -HEAD r270870+ and overall improve...
Status: Closed DUPLICATE of bug 193577
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-09-14 11:53 UTC by Daniel Engberg
Modified: 2014-10-31 10:05 UTC (History)
4 users (show)

See Also:
diizzy: maintainer-feedback? (squat)

Attachments
Working/Improved code for *BSD (1.70 KB, text/x-csrc)
2014-09-14 11:53 UTC, Daniel Engberg 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2014-09-14 11:53:00 UTC 
Created attachment 147309 [details]
Working/Improved code for *BSD

As per request I've made a separate PR.

Due to rearrangements in the base miniupnpd fails to compile without this patch. This was fixed by glebius@

This should replace the source file ./bsd
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2014-09-14 11:53:00 UTC 
Maintainer CC'd
Comment 2 Daniel Becker 2014-09-14 18:58:50 UTC 
Has this been submitted to upstream as well?
Comment 3 Daniel Engberg freebsd_committer freebsd_triage 2014-09-14 20:33:48 UTC 
Yes, glebius@ have submitted it.
Comment 4 Gleb Smirnoff freebsd_committer freebsd_triage 2014-09-15 11:16:51 UTC 
Change accepted upstream.
https://github.com/miniupnp/miniupnp/pull/93#event-165319903
Comment 5 John Marino freebsd_committer freebsd_triage 2014-10-31 09:35:40 UTC 
miniupnp was upgrade to 1.9 2 weeks ago.
Comment 6 Daniel Becker 2014-10-31 09:45:02 UTC 
This issue relates to miniupnp*d*, but the port that was upgraded is miniupnp*c*; they are not the same.
Comment 7 John Marino freebsd_committer freebsd_triage 2014-10-31 09:49:34 UTC 
why are there two competing PRs for the same port?

Can't these be combined to a single patch?
Comment 8 Daniel Becker 2014-10-31 09:57:31 UTC 
The patch attached to this issue here has been accepted into miniupnpd upstream, so it should just make it into the port on the next update.
Comment 9 John Marino freebsd_committer freebsd_triage 2014-10-31 10:05:45 UTC 
Fix will be incorporated in bug 193577

*** This bug has been marked as a duplicate of bug 193577 ***